Uh oh!
There was an error while loading. Please reload this page.
Makefile: target PHP 7.4 (and matrix 8.0-8.5), use phpcs.xml.dist - #37
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the local Makefile workflow to match the repository’s current PHP support floor and CI lint configuration.
Changes:
- Updates the default Docker PHP version from 7.2 to 7.4.
- Runs
phpcs/phpcbfwithphpcs.xml.distto match CI. - Simplifies the local
test-matrixtarget to PHP 7.4, with comments pointing to CI for the broader matrix.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
- PHP_VER default 7.2 -> 7.4 (composer now requires PHP >= 7.4, so the previous default fatal'd at composer platform_check.php). - Pass --standard=./phpcs.xml.dist to phpcs/phpcbf so local lint matches CI (and applies the mixed-type-hint exclusion). - test-matrix updated: PHP 7.4 + 8.0, 8.1, 8.2, 8.3, 8.4, 8.5 (drop EOL 5.6/7.0/7.1/7.2). graze/php-alpine ships -test tags for all of these. Verified end-to-end: `make test` (default 7.4) and `make PHP_VER=8.5 test` both pass — 131 tests / 696 assertions, OK. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
rick-lamforce-pushed
the
fix/makefile-php-versions
branch
from
May 28, 2026 16:54
a8926d1 to
e3bd8feCompareUh oh!
There was an error while loading. Please reload this page.
rick-lam added a commit
to graze/console-diff-renderer
that referenced
this pull request
May 28, 2026
….0-8.5 - lint/lint-fix pass --standard=./phpcs.xml so local lint matches CI. - test-matrix runs PHP 7.4 + 8.0, 8.1, 8.2, 8.3, 8.4, 8.5. Mirrors graze/parallel-process#37. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make testis broken on master because the Makefile defaults to PHP 7.2 and composer now requires PHP >= 7.4 — every target fatals at composer's platform check:Changes
PHP_VERdefault7.2→7.4(the supported floor).lint/lint-fixpass--standard=./phpcs.xml.distto phpcs/phpcbf so local lint matches CI (and applies the mixed-type-hint exclusion added in Add PHP 8.0-8.5 support #36).test-matrixupdated: PHP 7.4 + 8.0, 8.1, 8.2, 8.3, 8.4, 8.5 (drop EOL 5.6/7.0/7.1/7.2).graze/php-alpinepublishes-testtags for all of these, somake test-matrixactually runs the full matrix locally.Verification
make test(default PHP 7.4) → PHPUnit 9.6.34 on PHP 7.4.26: 131 tests / 696 assertions, OK.make PHP_VER=8.5 test→ PHPUnit 9.6.34 on PHP 8.5: 131 tests / 696 assertions, OK (with PHP 8.x deprecation notices that don't fail the suite — implicit-nullable params inDisplay\Lines/Display\Table,PriorityPoolSerializable,graze/data-structureCountable::countreturn type. Worth a follow-up issue but not a blocker).🤖 Generated with Claude Code