Uh oh!
There was an error while loading. Please reload this page.
Fix full height on mobile screens, close #62 - #75
Conversation
laurenziello
commented
Oct 27, 2020
@ArsalaBangash do you have some doubts about changes? |
ArsalaBangash
commented
Oct 28, 2020
Hi @laurenziello My apologies. I just got around to looking at this :) When I opened the deploy preview on my phone, this is what I got: What's the rationale behind min-100vh? |
laurenziello
commented
Oct 28, 2020
What's the rationale behind min-100vh? With height: 100vh you fix the height of the page to be the same of the screen device without any scoll. |
ArsalaBangash
commented
Oct 29, 2020
@laurenziello Thank you for the explanation. The changes you made work perfectly on the inspection window, but not on actual devices because of the URL bar. I wonder if there's a way to determine the available space on the screen and set the height accordingly. |
laurenziello
commented
Oct 29, 2020
@ArsalaBangash ok, I'll try this trick |
laurenziello
commented
Oct 30, 2020
@ArsalaBangash just made some changes to fix mobile devices problem. Please check if it works. |
ArsalaBangash
commented
Oct 31, 2020
@laurenziello I made some refactoring changes to our project structure, which is now causing conflicts. I've added the label. |


No description provided.