Frameworks are not all Rails - #54
Open
pboling wants to merge 2 commits into
Open
Conversation
Non-Rails apps, like Grape, Sinatra, etc, which may use ActiveRecord, still have need of the ability to test `after_commit`.
Grape, Sinatra, and other Ruby frameworks, may use ActiveRecord, but be unable to utilize Rails' built-in `use_transactional_tests`, due to it not being part of ActiveRecord, but instead part of Rails proper.
grosser
reviewed
Aug 30, 2022
grosser
left a comment
Owner
There was a problem hiding this comment.
it's baked into AR 5+ so should not be needed for grape either ?
Author
It would be nice if that were true.
|
grosser
reviewed
Sep 9, 2022
| s.required_ruby_version = '>= 2.0.0' | ||
| s.add_runtime_dependency "activerecord", [">= 3.2", "< 5.0"] | ||
| s.add_runtime_dependency "activerecord", ">= 3.2" |
Owner
There was a problem hiding this comment.
this should be < 7.1 and add the missing gemfiles
(can remove all the old 4.x gemfiles)
and update the readme to say that this makes sense for non-rails only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using this with active record within a framework like Grape, it is still useful.
From my commit messages: