terraform-fmt updates files, optionally skipped via flags

[tyron]

Restore terraform-fmt behaviour from v0.1.11. Fixes#48.

By default, changes are written back to source files as usual for pre-commit hooks, but can be optionally disabled by providing a --no-autofix flag to terraform-fmt.

[tyron]

This is required to be able to run the hook outside the repo folder. For example, pre-commit try-repo /path/to/local/hook terraform-fmt would invoke terraform fmt with files relative to that /path/to/local/hook. By providing the entire dirname, we can use the pre-commit tool for local development easily.

[tyron]

@brikis98 , @yorinasub17 please let me know if this is OK to be reviewed, or if you'd prefer that we don't revert the default behaviour -- rather just expose the flag to switch to the old one.

[tyron]

Inspired on shellcheck.sh's version:

pre-commit/hooks/shellcheck.sh

Line 13 in e9250bd

parse_arguments() {

[joshmyers]

Any movement on this? Seems a few folks would like old behavior

[mleuthold]

Just my 2cents:

I thought with 1.1.17 this would have been fixed by now. Because it is not, I will still continue using 0.1.11 for auto format files.

[ysawa0]

+1 on this change. Printing the diff is not as useful as auto-correcting the styling.

[ad-m-ss]

Is there anything what I can do to make that change happen?

[ad-m-ss]

If anyone interested that change can be easily tested eg. via:

- repo: https://github.com/gruntwork-io/pre-commit
rev: 837cfa83f27ec2dd4a4c6860b2a6ca9392642fe0
hooks:
- id: terraform-fmt
- id: terraform-validate
exclude: terragrunt/modules

[sanguis]

while this is not complete its better then the current fuctionality

[ayk33]

Can we get some traction on this. The previous functionality is much nicer.

[Fez29]

Also waiting on this functionality

[Tlunch]

Would be good to see this functionality

[jannikmi]

I found this functionality in another repository:
https://github.com/antonbabenko/pre-commit-terraform?tab=readme-ov-file#terraform_fmt

 - repo: https://github.com/antonbabenko/pre-commit-terraform
rev: v1.92.2
hooks:
- id: terraform_fmt

[dbowling]

Looks like this also fixes #138

As far as I can see, we're just missing code review. Can any maintainer help?

I might suggest that the default be evaluated as it is a change in behavior. Though I personally prefer the default being to auto-fix.