fix(social): render generated images in workerd - #336
Merged
Merged
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-01a099b9-5ce7-7238-860f-2dd12b1a82b2 Co-authored-by: Guide Fari <guideg6@gmail.com>
guidefari
commented
Sep 18, 2026
| "type": "module", | ||
| "scripts": { | ||
| "test": "vitest run", | ||
| "test": "vitest run src/render.test.tsx && vitest run --config vitest.workerd.config.ts", |
Owner
Author
There was a problem hiding this comment.
Agreed. Followed up in #337: the package is back to a single vitest run, and the retry case now runs under the same workerd configuration and production-style WASM/assets as the rest of the worker tests.
Amp-Thread-ID: https://ampcode.com/threads/T-01a099b9-5ce7-7238-860f-2dd12b1a82b2 Co-authored-by: Guide Fari <guideg6@gmail.com>
github-actions Bot
pushed a commit
that referenced
this pull request
Sep 18, 2026
## [2.96.1](v2.96.0...v2.96.1) (2026-09-18) ### Bug Fixes * **social:** render generated images in workerd ([#336](#336)) ([7087dc8](7087dc8))
|
🎉 This PR is included in version 2.96.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #335.
Production Open Graph image requests failed because the worker attempted to compile Yoga and Resvg WASM at request time, which workerd disallows. This imports both binaries as compiled Worker modules and upgrades Satori to the release that correctly accepts a
WebAssembly.Module; fonts and remote artwork continue through the existing asset loaders.The regression suite now executes both the worker request path and a real PNG rasterization inside workerd, and is included in the repository-wide test command.
Validation
bun run testbun precommitTest evidence
A production-model tweet card rendered by the same workerd path now covered by CI (1200×630 PNG, with artwork, author metadata, and track presentation intact):