sort mx records by priority (lowest first) - #57
Merged
Conversation
Collaborator
@seasick thank you for the pr - anything else you see that needs work? I will push within the next couple of days |
seasick
commented
Oct 15, 2018
ContributorAuthor
@GreenPioneer, you are welcome. Noticed it, though it is an easy fix. Even without that fix, it works like a charm :) |
luisesn
commented
Jun 17, 2019
No news from this? |
9 months ago:
@GreenPioneer : This PR is really important. As-is, you will always send to the wrong SMTP server, if there are backup fallback servers. |
GreenPioneer
commented
Jul 4, 2019
Collaborator
@seasick thanks again and my bad on it taking so dang long to get it in I don't know how I wasn't notified by @luisesn message but I was with @benbucksch message Will be publishing to NPM momentarily |
GreenPioneer
commented
Jul 4, 2019
Collaborator
benbucksch
commented
Jul 4, 2019
@GreenPioneer : Thanks! |
luisesn
commented
Jul 4, 2019
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taken from https://en.wikipedia.org/wiki/MX_record#Priority
Description
Currently the mail is sent by using the MX record with the highest priority. This PR changes it to use the record with the lowest priority first.
Types of changes
Checklist: