') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Stash interface by raphaelcastaneda · Pull Request #106 · guykisel/inline-plz · GitHub
Skip to content

Stash interface - #106

Open
raphaelcastaneda wants to merge 19 commits into
masterfrom
stash-interface
Open

Stash interface#106
raphaelcastaneda wants to merge 19 commits into
masterfrom
stash-interface

Conversation

@raphaelcastaneda

@raphaelcastanedaraphaelcastaneda commented Mar 16, 2016

Copy link
Copy Markdown
Collaborator

Added interface for Atlassian Stash

@raphaelcastaneda

raphaelcastaneda commented Mar 16, 2016

Copy link
Copy Markdown
CollaboratorAuthor

It seems this build will fail until this is resolved: cosmin/stashy#62
The (really outdated) version of Stashy on PyPI has a conflicting requirement for requests, and is missing some API endpoints we're using. I'll need to specify stashy>=0.3

@guykisel

guykisel commented Mar 16, 2016

Copy link
Copy Markdown
Owner

for testing purposes in the PR i think it's okay to have it depend directly on the git repo. for merging i'd be okay with depending on the git repo if we can find a way to make it optional so that things dont break if you dont have a connection to github.

guykisel
guykisel reviewed Mar 16, 2016
View reviewed changes
Comment threadinlineplz/interfaces/stash.py
return False

@staticmethod
def format_message(message):

@guykiselguykiselMar 16, 2016

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wonder if this should be moved to the parent class or to a utility module. thoughts?

@raphaelcastanedaraphaelcastanedaMar 16, 2016

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the implementation here is slightly different from github.py because the structure of comments in the stash API is different. I couldn't think of a good way to extract the shared logic from what is unique to each interface. Any suggestions?

@guykiselguykiselMar 16, 2016

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah i didn't notice the difference, nevermind

raphaelcastaneda
raphaelcastaneda reviewed Mar 16, 2016
View reviewed changes
Comment threadinlineplz/main.py Outdated
repo: Repository name
pr: Pull request ID
token: Authentication for repository
username: (If not using token) username for repository

@raphaelcastanedaraphaelcastanedaMar 16, 2016

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, that's wrong. Should be user

guykisel
guykisel reviewed Mar 16, 2016
View reviewed changes
Comment threadinlineplz/interfaces/stash.py


class StashInterface(InterfaceBase):
def __init__(self, project, repo, pr, auth, url=None):

@guykiselguykiselMar 16, 2016

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prospector: pylint: Too many arguments (6/5) (too-many-arguments)

Raphael Castaneda added 5 commits March 16, 2016 15:31
guykisel
guykisel reviewed Apr 18, 2016
View reviewed changes
Comment threadinlineplz/interfaces/stash.py
# -*- coding: utf-8 -*-
from __future__ import absolute_import

import stashy

@guykiselguykiselApr 18, 2016

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prospector: pylint: Unable to import 'stashy' (import-error)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@raphaelcastaneda@guykisel