Avoid warning message from array_merge in autoload for sites without classes/ or handlers/ - #29
Closed
jonhoo wants to merge 1 commit into
Closed
Avoid warning message from array_merge in autoload for sites without classes/ or handlers/#29jonhoo wants to merge 1 commit into
jonhoo wants to merge 1 commit into
Conversation
Make calls to glob() use Utils::glob both for consistency and to prevent PHP warning if site has empty /classes/ or /handlers/ folders. Utils::glob always returns an array, and so array_merge won't yield a warning, whereas plain glob() will.
Member
|
I think using a potentially autoloaded class inside the autoloader is troublesome. |
Contributor
Author
|
Replaced by pull request #30 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make calls to glob() use Utils::glob both for consistency and to prevent PHP warning if site has empty /classes/ or /handlers/ folders.
Utils::glob always returns an array, and so array_merge won't yield a warning, whereas plain glob() will.