Adding patch for Trac ticket #1313. - #3
Closed
Konzertheld wants to merge 1 commit into
Closed
Conversation
Member
|
http://trac.habariproject.org/habari/ticket/1313 for reference (why isn't this in the issues?) |
Member
Author
|
It is. Github ticket 136. For some reason searching for "xml" does not find it. |
Member
|
I added a bunch of notes to this commit. I'm afraid it's got a lot of problems, least of which are the whitespace changes that make it a lot harder to see what actually happened. I think this is something we should investigate further. I'll leave this pull request open so if you want to clean up some of the problems I noted their commits can be added to later. Also note that Github says this request cannot be automatically merged, so someone needs to figure out why not and address that... probably just one of the whitespace changes causing a conflict. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding patch for Trac ticket #1313. Props to rynodivino. Needs finetuning.