Skip to content

Coder Kid's Hackpad - #134

Merged
qcoral merged 16 commits into
hackclub:mainfrom
0CODERKID:main
Oct 24, 2024
Merged

Coder Kid's Hackpad #134
qcoral merged 16 commits into
hackclub:mainfrom
0CODERKID:main

Conversation

@0CODERKID

Copy link
Copy Markdown
Contributor

Ready to submit your project? Nice job! Hopefully you've read the submission guidelines. If not, make sure to read them first.

If you're unsure about the format, make sure to check out the Orpheuspad example and follow the format there.

If this PR isn't a submission, that's okay too! If there's anything about this PR template that seems confusing, let me know in #hackpad on the slack!

@vercel

vercelBot commented Oct 20, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
hackpad✅ Ready (Inspect)Visit Preview💬 Add feedbackOct 24, 2024 5:43pm

@0CODERKID0CODERKID changed the title first commitCoder Kid's HackpadOct 21, 2024
@0CODERKID0CODERKID changed the title Coder Kid's HackpadCoder Kid's Hackpad ( ADDING my CAD within a week!! ;() Oct 22, 2024
@0CODERKID0CODERKID changed the title Coder Kid's Hackpad ( ADDING my CAD within a week!! ;() Coder Kid's Hackpad ( ADDING my CAD within a week!! ;() )Oct 22, 2024
@Dongathan-JongDongathan-Jong self-assigned this Oct 23, 2024
@cheyao

cheyao commented Oct 23, 2024

Copy link
Copy Markdown
Contributor

Hello!

Please rename the directories to the required names, for example My PCB to `PCB. And please remove the spaces in the file names, it's kinda frustrating to type names with spaces in the terminal.

And I don't see a case in your project

The PCB is ok. No big problems.

The firmware looks copy-pasted, you still got example username and yourwebsite.com there? I think you should modify it to be a bit less template-y.

Anyways I'll approve after you make some changes.

@0CODERKID

Copy link
Copy Markdown
ContributorAuthor

Hi , i renamed the name from 'MY PCB' to 'PCB' , Also I can't find any spaces in any files name
.. and the entire code is written by me .. not copied it from anywhere

Also i didn't understood wdym by " you still got example username and yourwebsite.com there? I think you should modify it to be a bit less template-y. "

@0CODERKID

Copy link
Copy Markdown
ContributorAuthor

And yea , I'm really struggling with the case .. i asked from alex to give me a week more .. and he approved me , so can you pls wait wait for some more time? and pls send you're slack username so i can inform you whether my pr is fully done or not

@cheyao

Copy link
Copy Markdown
Contributor

You see here:
image
There are links like C:\\Users\\YourUsername and https://yourwebsite.com, which are common in tutorials, thus I thought that you directly copied the code. Sorry if I'm mistaken. But you should probably modify this to something that is more your own.

Here you see, there are spaces in the file names, but just leave it so. It is just a tiny nuisance.
image

My slack is @cyao feel free to ping me when you are dome :D

@0CODERKID0CODERKID changed the title Coder Kid's Hackpad ( ADDING my CAD within a week!! ;() )Coder Kid's Hackpad Oct 24, 2024

@cheyaocheyao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh hate to say it but you are using the wrong footprint for the xiao. See in your pcb vcc is in the bottom right
image
But it should be in the top right
image
So your row 2 is currently connected to 5V

You should also change the xiao schematic to a more accurate one. (Download it from the OPL lib)

In the CAD your USB hole isn't a hole
image

And what are these holes for? You will have a PCB in the middle without holes so you can't put screws in them
image

@0CODERKID

Copy link
Copy Markdown
ContributorAuthor

Did all the changes!

@souptik-samantasouptik-samanta left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the 7)
"All the components are through-hole "
I dont think so its needed
: )

@0CODERKID

Copy link
Copy Markdown
ContributorAuthor

please remove the 7) "All the components are through-hole " : )

Done

@souptik-samantasouptik-samanta left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve #85

@shim-sham

Copy link
Copy Markdown
Contributor

I approve #181

@jpt1729jpt1729 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

#7

@cheyao

Copy link
Copy Markdown
Contributor

LGTM #4

@invictus-anic3tus

Copy link
Copy Markdown
Contributor

I approve #92
very nice looking

@qcoral

qcoral commented Oct 24, 2024

Copy link
Copy Markdown
Member

damn y'all 😭

Approved, you can get it here https://forms.hackclub.com/hackpad

have fun and thanks everyone for reviewing!

@qcoral
qcoral merged commit 436b5a6 into hackclub:mainOct 24, 2024
@0CODERKID0CODERKID mentioned this pull request Nov 5, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@0CODERKID@cheyao@shim-sham@invictus-anic3tus@qcoral@jpt1729@souptik-samanta@Dongathan-Jong