Uh oh!
There was an error while loading. Please reload this page.
Add ScrollPad - #579
Merged
Merged
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
- Change GPIO pin assignments - PCB improvements: add mounting holes, LED position, routing - Case improvements: add spacer, cover fix, add Skadis holder - Update firmware: add LED layer indication, add mouse scrolling keys, change keys
nathantsai1
commented
Mar 8, 2025
Contributor
Hi @Illuminum2, Nice hackpad! Just a minor thing...
Otherwise, It looks fine! I approve of this submission! Here's my own approved PR link: #228 |
danieliscrazy
suggested changes
Mar 16, 2025
danieliscrazy
left a comment
Contributor
There was a problem hiding this comment.
Hey there! It appears your case is missing branding. All parts of your case must be branded. Once you've fixed this, I'll give you my approval!
Illuminum2
commented
Mar 20, 2025
ContributorAuthor
Hi, I added the branding |
return-misaPuding
left a comment
Contributor
There was a problem hiding this comment.
LGTM (my accepted PR is #634 ), it´s nice to see macropads used for solving some problem!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added my hackpad