Skip to content

Feat/assign reviewers - #959

Merged
tektaxi merged 4 commits into
devfrom
feat/assign_reviewers
Nov 20, 2025
Merged

Feat/assign reviewers#959
tektaxi merged 4 commits into
devfrom
feat/assign_reviewers

Conversation

@tektaxi

@tektaxitektaxi commented Nov 19, 2025

Copy link
Copy Markdown
Contributor

see #957 for details.

@tektaxitektaxi mentioned this pull request Nov 19, 2025
Closed
12 tasks
tektaxi
tektaxi commented Nov 19, 2025
View reviewed changes
Comment threadconstants/routes.constant.js
uri: "/api/hacker/reviewerComments2/" + Constants.ROLE_CATEGORIES.SELF,
_id: mongoose.Types.ObjectId.createFromTime(179)
},
// patchAnyReviewerNameById: {

@tektaxitektaxiNov 19, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is all commented out, can we just delete it? is there a reason to keep?

Comment threadmiddlewares/hacker.middleware.js


/**
* Updates a hacker that is specified by req.params.id, and then sets req.email

@tektaxitektaxiNov 19, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make this comment accurate? i think it's just copy pasted?

Comment threadroutes/api/hacker.js
*/
hackerRouter.route("/assignReviewers").post(
// Middleware.Validator.RouteParam.idValidator,
// Middleware.Auth.ensureAuthenticated(),

@tektaxitektaxiNov 19, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's try to enable the auth ones at least

@tektaxitektaxiNov 19, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should also add this route to the Hackboard role "excludes"

@tektaxitektaxiNov 19, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait i just realized if we're running this as a script for now we can't have these on

@tektaxi

tektaxi commented Nov 20, 2025

Copy link
Copy Markdown
ContributorAuthor

overriding review requirements because it's basically Jamie's PR and I approve

@tektaxi

tektaxi commented Nov 20, 2025

Copy link
Copy Markdown
ContributorAuthor

@JamieXiao make sure to address comments in the next one, just merging bc we have to use tonight.

@tektaxi
tektaxi merged commit e19d58c into devNov 20, 2025
1 check failed
@tektaxi
tektaxi deleted the feat/assign_reviewers branch November 20, 2025 20:04
joshuazhou744 pushed a commit that referenced this pull request Jan 15, 2026
@tektaxi@JamieXiaoJoshua Zhou
Feat/assign reviewers (#959)
e3b6f8d
* Assign 2 reviewers per unreviewed Hacker submitted before cutoff time. Will need a cleaning for documentation
* removed to requirement that the reviewer name has to be empty (now it's just filtering if hacker was created before cutoff)
* clean
* Use string[] parameter instead of hardcoded names
---------
Co-authored-by: JAMIE XIAO <jamie.xiao.ca@gmail.com>
tektaxi added a commit that referenced this pull request Jan 17, 2026
@joshuazhou744Joshua Zhou
@janekhuong@MikaVohl@tektaxi@JamieXiao@MubeenMohammed
Feat/Team Checkin Form routes, validators, controllers, and middleware (
b36c5ea
#974)
* Create checkin form submit endpoint
* Finish hacker checkin form submit endpoint
* Change checkin form spreadsheet
* api route for checking in teams
* Add devpost and discord tag field validation
* Update db with devpost url
* Add url validation:
* added team checkin form status to settings
* remove workshops
* more validation
* test
* Updated email template dates and header logo
* Added hackboard role support
* Revert "Added hackboard role support"
This reverts commit 481d303.
* Feat/auto emails (#949)
* Update email templates with tentative dates
* Create service for sending automated status emails
* Created function to find hacker by their status
* API routing for automated emails
* Cleaner code
* API routing for getStatusCount function
* Added emails.js logic to middleware and controller files
* fixed authorization bug
* Added hackboard role support
* Revert "Added hackboard role support"
This reverts commit 481d303.
* update email dates
---------
Co-authored-by: Joshua Zhou <joshuazhou744@gmail.com>
Co-authored-by: Mika Vohl <mikavohl@gmail.com>
Co-authored-by: Tavi Pollard <tavienpollard@gmail.com>
* Feat/create application review (#944)
* not finished create app rev
* Reviewer status: 1/2 works (needs to enter twice??)
* Hacker Reviewer Feature
* Cleaner code
* remove uneccessary comments
* not finished create app rev
* Reviewer status: 1/2 works (needs to enter twice??)
* Hacker Reviewer Feature
* Cleaner code
* remove uneccessary comments
* not finished create app rev
* Reviewer status: 1/2 works (needs to enter twice??)
* Hacker Reviewer Feature
* Cleaner code
* remove uneccessary comments
* not finished create app rev
* Reviewer status: 1/2 works (needs to enter twice??)
* Hacker Reviewer Feature
* Cleaner code
* Fixed Application Error: implemented reviewers values from feat/review_filter and fixed the default value errors for reviewer status, name, and comments
* Fixed Application Error: implemented reviewers values from feat/review_filter and fixed the default value errors for reviewer status, name, and comments
* fixed authorization issues by adding all routes to routes.constant.js with unique IDs
* disable emails on status change by admin
---------
Co-authored-by: Tavi Pollard <tavienpollard@gmail.com>
Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com>
* fixed merge issue with objectIDs
* Added hackboard role support (#955)
* Added hackboard role support
* minor edits to hackboard permissions
---------
Co-authored-by: Tavi Pollard <tavienpollard@gmail.com>
* Updated account invitation email content
* Feat/assign reviewers (#959)
* Assign 2 reviewers per unreviewed Hacker submitted before cutoff time. Will need a cleaning for documentation
* removed to requirement that the reviewer name has to be empty (now it's just filtering if hacker was created before cutoff)
* clean
* Use string[] parameter instead of hardcoded names
---------
Co-authored-by: JAMIE XIAO <jamie.xiao.ca@gmail.com>
* Added script for sending interest form emails (#954)
* Added script for sending interest form emails
* Usage comments
* quick fixes to assignReviewers (#961)
* quick fixes to assignreviewers
* fixed non existant fields conditional statements for assignReviewers
* need to fix: reviewer1 & 2 have same name
* fixed duplicate names
* cut off to dec 1 11:59 pm
* update cutoff
* date fix??
* add hacker id to team api response schema
* new acceptance email
* updated Marriott booking deadline
* round 2 acceptance email template
* updated rejection email
* updated wording
* added volunteer link
* added applied status to validateStatus function
* overrode email template to send declined emails to hackers with applied status (#972)
* Finish hacker checkin form submit endpoint
* format sheet name
* remove checkin router dup
* fix
---------
Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca>
Co-authored-by: janekhuong <janekhuong05@gmail.com>
Co-authored-by: Mika Vohl <mikavohl@gmail.com>
Co-authored-by: Tavi Pollard <tavienpollard@gmail.com>
Co-authored-by: Jamie Xiao <141690843+JamieXiao@users.noreply.github.com>
Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com>
Co-authored-by: Mika Vohl <103958325+MikaVohl@users.noreply.github.com>
Co-authored-by: JAMIE XIAO <jamie.xiao.ca@gmail.com>
Co-authored-by: Mubeen Mohammed <mubeen.mohammed@mail.mcgill.ca>
@tektaxitektaxi mentioned this pull request Jan 17, 2026
Merged
16 tasks
tektaxi added a commit that referenced this pull request Jan 17, 2026
@joshuazhou744Joshua Zhou
@janekhuong@MikaVohl@tektaxi@JamieXiao@MubeenMohammed
Feat/Team Checkin Form routes, validators, controllers, and middleware (
657ccfa
#974)
* Create checkin form submit endpoint
* Finish hacker checkin form submit endpoint
* Change checkin form spreadsheet
* api route for checking in teams
* Add devpost and discord tag field validation
* Update db with devpost url
* Add url validation:
* added team checkin form status to settings
* remove workshops
* more validation
* test
* Updated email template dates and header logo
* Added hackboard role support
* Revert "Added hackboard role support"
This reverts commit 481d303.
* Feat/auto emails (#949)
* Update email templates with tentative dates
* Create service for sending automated status emails
* Created function to find hacker by their status
* API routing for automated emails
* Cleaner code
* API routing for getStatusCount function
* Added emails.js logic to middleware and controller files
* fixed authorization bug
* Added hackboard role support
* Revert "Added hackboard role support"
This reverts commit 481d303.
* update email dates
---------
Co-authored-by: Joshua Zhou <joshuazhou744@gmail.com>
Co-authored-by: Mika Vohl <mikavohl@gmail.com>
Co-authored-by: Tavi Pollard <tavienpollard@gmail.com>
* Feat/create application review (#944)
* not finished create app rev
* Reviewer status: 1/2 works (needs to enter twice??)
* Hacker Reviewer Feature
* Cleaner code
* remove uneccessary comments
* not finished create app rev
* Reviewer status: 1/2 works (needs to enter twice??)
* Hacker Reviewer Feature
* Cleaner code
* remove uneccessary comments
* not finished create app rev
* Reviewer status: 1/2 works (needs to enter twice??)
* Hacker Reviewer Feature
* Cleaner code
* remove uneccessary comments
* not finished create app rev
* Reviewer status: 1/2 works (needs to enter twice??)
* Hacker Reviewer Feature
* Cleaner code
* Fixed Application Error: implemented reviewers values from feat/review_filter and fixed the default value errors for reviewer status, name, and comments
* Fixed Application Error: implemented reviewers values from feat/review_filter and fixed the default value errors for reviewer status, name, and comments
* fixed authorization issues by adding all routes to routes.constant.js with unique IDs
* disable emails on status change by admin
---------
Co-authored-by: Tavi Pollard <tavienpollard@gmail.com>
Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com>
* fixed merge issue with objectIDs
* Added hackboard role support (#955)
* Added hackboard role support
* minor edits to hackboard permissions
---------
Co-authored-by: Tavi Pollard <tavienpollard@gmail.com>
* Updated account invitation email content
* Feat/assign reviewers (#959)
* Assign 2 reviewers per unreviewed Hacker submitted before cutoff time. Will need a cleaning for documentation
* removed to requirement that the reviewer name has to be empty (now it's just filtering if hacker was created before cutoff)
* clean
* Use string[] parameter instead of hardcoded names
---------
Co-authored-by: JAMIE XIAO <jamie.xiao.ca@gmail.com>
* Added script for sending interest form emails (#954)
* Added script for sending interest form emails
* Usage comments
* quick fixes to assignReviewers (#961)
* quick fixes to assignreviewers
* fixed non existant fields conditional statements for assignReviewers
* need to fix: reviewer1 & 2 have same name
* fixed duplicate names
* cut off to dec 1 11:59 pm
* update cutoff
* date fix??
* add hacker id to team api response schema
* new acceptance email
* updated Marriott booking deadline
* round 2 acceptance email template
* updated rejection email
* updated wording
* added volunteer link
* added applied status to validateStatus function
* overrode email template to send declined emails to hackers with applied status (#972)
* Finish hacker checkin form submit endpoint
* format sheet name
* remove checkin router dup
* fix
---------
Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca>
Co-authored-by: janekhuong <janekhuong05@gmail.com>
Co-authored-by: Mika Vohl <mikavohl@gmail.com>
Co-authored-by: Tavi Pollard <tavienpollard@gmail.com>
Co-authored-by: Jamie Xiao <141690843+JamieXiao@users.noreply.github.com>
Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com>
Co-authored-by: Mika Vohl <103958325+MikaVohl@users.noreply.github.com>
Co-authored-by: JAMIE XIAO <jamie.xiao.ca@gmail.com>
Co-authored-by: Mubeen Mohammed <mubeen.mohammed@mail.mcgill.ca>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JamieXiaoJamieXiaoAwaiting requested review from JamieXiao

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tektaxi@JamieXiao