chore(deps): bump rustls-webpki and rand for Dependabot alerts - #17
Merged
Conversation
- rustls-webpki 0.103.11 → 0.103.12 (GHSA-965h-392x-2mh5, GHSA-xgp8-3hg3-c2mh): two low-severity name-constraint parsing flaws. Not exploitable for our Anthropic API usage (public CA-signed certs), but a trivial lockfile bump. - rand 0.8.5 → 0.8.6 (GHSA-cq8v-f236-94qc): unsound-with-custom-logger advisory lists 0.9.3+ as the patched series, but 0.8.6 is the latest 0.8.x that cargo can reach through current transitive deps. 0.9.x is gated behind upstream crates that still depend on 0.8.x. We do not install a custom logger that reentrantly calls rand, so real-world impact is nil either way.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Address 3 low-severity Dependabot alerts via
Cargo.lock-only updates, plus evidence on why the rand alert is effectively a false positive.rustls-webpkiGHSA-965h-392x-2mh5(URI name constraints) andGHSA-xgp8-3hg3-c2mh(wildcard name constraints). Actually in our compiled binary viareqwest → rustls.randGHSA-cq8v-f236-94qclists 0.9.3+ as patched, but see the note below — this code isn't actually compiled for our feature set.Why not just bump
randto 0.9.x?randis not a direct dependency. It entersCargo.lockonly through this chain:phf_generator 0.11.3is pinned torand 0.8.x— rand 0.9.x has breaking API changes and requires an upstreamphf_generatorrelease to consume.[patch.crates-io]would almost certainly fail to compilephf_generator— no actual security benefit.cargo tree(default features, default target) shows norandin the active build graph — onlyfastrand, a different crate. The termwiz backend that drags inrandis not enabled; we use crossterm.randis inCargo.lockbecause Cargo pre-resolves every possible feature / target combo, but the vulnerable code path is never compiled into our binary.The 0.8.6 bump is applied as best-effort hygiene. If GitHub's Dependabot still considers the alert open after merge (because 0.8.6 is in the
< 0.9.3advisory range), dismiss as "Not affected" — it's accurate.Why the
rustls-webpkibump mattersrustls-webpkiis compiled into our binary viareqwest → rustls. The name-constraint flaws affect TLS clients verifying untrusted server certs — we only connect to Anthropic's public-CA-signed API, so the flaws aren't exploitable for us, but the bump is free and cleanly closes both alerts.Test plan
cargo build— compilescargo test— 600 pass (no test changes)cargo tree— confirms norandin the active build graph (onlyfastrand, which is unrelated)