Uh oh!
There was an error while loading. Please reload this page.
[HAL-1287] - add capability to display warnings that come from WFCORE… - #383
[HAL-1287] - add capability to display warnings that come from WFCORE…#383baranowb wants to merge 2 commits into
Conversation
| @Override | ||
| public boolean accepts(ModelNode response) { | ||
| // result->step-x->response-headers->warnings | ||
| if (response.hasDefined(RESULT)) { |
There was a problem hiding this comment.
Is the model node structure the same for both standalone and domain?
There was a problem hiding this comment.
iirc yeah, Im going to update this PR since there has been change in core WRT this.
Also, I assume that every op is a "stepped" operation. Not sure if this is correct?
There was a problem hiding this comment.
I don't think so. Steps are usually only used for composite operations. I guess this is also true for this use case. I suggest to talk to Brian, to clarify the exact response structure.
There was a problem hiding this comment.
well, but I think console use only composite operation?
There was a problem hiding this comment.
Right, but that might change - and there might be other operations which cause these response headers. So it would be more robust to be prepared for warnings which are not wrapped inside steps.
hpehl
commented
Feb 22, 2017
I've put this on hold, since we're beyond EAP 7.1 code freeze. Only bugfixes (JBEAP issues) are allowed for master. Merging this will be postponed until 7.1 has been released. |
baranowb
commented
Feb 24, 2017
There is one tiny detail that is wrong with this PR, Im trying to solve it. |
…-1987
https://issues.jboss.org/browse/HAL-1287