Uh oh!
There was an error while loading. Please reload this page.
Add LocMapper action - #14
Open
JulienBreux wants to merge 3 commits into
Open
Conversation
Signed-off-by: Julien Breux <julien.breux@happn.fr>
DevHugo
reviewed
Sep 24, 2021
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Hugo Courtecuisse <DevHugo@users.noreply.github.com>
Co-authored-by: Hugo Courtecuisse <DevHugo@users.noreply.github.com>
DevHugo
reviewed
Sep 27, 2021
| using: 'docker' | ||
| image: 'Dockerfile' | ||
| args: | ||
| - ${{ inputs.command }} |
There was a problem hiding this comment.
ags are passed on entrypoints.sh argument. See the docs: https://github.com/happn-tech/LocMapper/blob/main/Dockerfile#L49 .
I think it needed to create an entrypoint.sh file. Somethink like in the Dockerfile :
USER root
ADD entrypoint.sh .
RUN chmod +x entrypoint.sh && chown locmapper entrypoint.sh
ENTRYPOINT ["/locmapper/entrypoint.sh"]
and entrypoint.sh :
#!/bin/sh
locmapper $1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add missing custom LocMapper tool action.
Reviewers note
Important to understand that in a very first time, we just pass one input "command".
In the future, it's better to split in relation of the tools commands, sub-commands and arguments.