Uh oh!
There was an error while loading. Please reload this page.
chore(deps): update dependency isort to v8 - #60
Conversation
949b01f to
87d5fa3Compare
pkyosx
left a comment
There was a problem hiding this comment.
Auto-approved: renovate dependency upgrade (isort v8) — all CI checks passing.
87d5fa3 to
05fa625Compare05fa625 to
c6a9d74Compare📝 WalkthroughWalkthroughThis PR updates the ChangesDevelopment Dependency Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~1 minute 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@requirements-dev.txt`:
- Line 6: The isort version in requirements-dev.txt is 8.0.1 but the pre-commit
hook still pins an older rev; update the isort hook entry in your
.pre-commit-config.yaml so its rev matches the isort 8.0.1 release (e.g., set
the isort hook's rev to "8.0.1" or run pre-commit autoupdate for the isort
repo), then reinstall or run pre-commit to verify hooks use the same isort
version as requirements-dev.txt.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 932c239f-2ed7-4159-bde6-ceaa8919db49
📒 Files selected for processing (1)
requirements-dev.txt
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: pre-commit
🔇 Additional comments (1)
requirements-dev.txt (1)
6-6: Check isort 8 upgrade compatibility with existing config (legacy “old finders” removed).isort 8.0.0 removed the legacy finder behavior: CLI flags
--old-findersand--magic-placementand the config optionold_finders. Search yoursetup.cfg/pyproject.tomlforold_finders(and any references to those flags) and migrate to the non-legacy placement configuration before/along with upgrading toisort==8.0.1. The earlier examples of other config keys being deprecated/removed aren’t supported by the isort 8.0.0 breaking-change info gathered here—those would need a separate config-specific check.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This PR contains the following updates:
==5.13.2→==8.0.1Release Notes
PyCQA/isort (isort)
v8.0.1Compare Source
Changes
v8.0.0Compare Source
--old-findersand--magic-placementflags andold_findersconfiguration option. The legacy finder logic that relied on environment introspection has been removed (#2445) @joao-faria-devploneprofile to not clash withblack(#2456) @ale-rtv7.0.0Compare Source
Changes
💥 Breaking Changes
🚀 Features
🪲 Fixes
3.14and fix any bugs (#2425) @DanielNoord👷 Continuous Integration
ruffinstead ofblack(#2432) @DanielNoordruff(#2431) @DanielNoord📦 Dependencies
v6.1.0Compare Source
v6.0.1Compare Source
v6.0.0Compare Source
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.