Skip to content

Extension sessions stage SKILL.md only — companion files dead-link; plus three skill-text fixes #393

Description

@aarontrowbridge

Important

Problem — (1) stageOpencodeSkills (packages/extension/src/scores/package_skills.ts) copies only SKILL.md into the per-session stage dir, but 16 shipped skills carry companion files (tdd's five craft docs, debugging's two, teach's four, nine references/ dirs, …). Every relative link in the staged copy dead-ends in extension sessions, even though skillGrants already grants the agent the ENTIRE source skill dir — the content is permitted but not present. (2) Three smaller text rots from the 2026-08-16 audit: improve-codebase-architecture says "use the Agent tool with subagent_type=Explore" (Claude-ism; on opencode the dispatch tool is Task); amico-slack's link-format example points at a PR in the retired amico-plugin repo; amico-lab's device-lock instruction says "create ~/.amico/ops/locks/devices/{name}.lock" without creating the parent dir (absent on a fresh machine).
Approach — (1) Stage the whole resolved skill dir (fs.cpSync recursive). No guard change: the stage dir still holds ONLY the resolved set — the only-resolved-set test assertion stays true — and companions were already readable via grants, so nothing new is exposed. Extend the stageOpencodeSkills test to pin companion staging. (2) Engine-neutral dispatch wording; live-repo example URL; mkdir -p in the lock instruction.

Acceptance Criteria

  • A skill with companion files stages them: <stageRoot>/<name>/<companion> exists after stageOpencodeSkills, and only resolved skills' dirs appear at the stage root
  • The existing suite stays green (vitest run --exclude '**/slow/**' in packages/extension) and tsc --noEmit passes
  • improve-codebase-architecture names no engine-specific tool as the only path (engine-neutral wording)
  • amico-slack's example link points at a live harmoniqs repo
  • amico-lab's lock instruction creates the parent directory

Testing Decisions

Extend the existing stageOpencodeSkills describe block in test/scores/package_skills.test.ts (reuse-first).

Source

Audit session 2026-08-16; armonissima-side remediation in armonissima#54/#55.

Notes

Companions affected: tdd (5), debugging (2), grill-with-docs (2), teach (4), improve-codebase-architecture (3), brainstorming (1), references/ dirs in atoms, bosonic, demo, harmony, pasqal, problem-types, qec-autoresearch, setup, solve.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    hitlNeeds human decision or review

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions