Uh oh!
There was an error while loading. Please reload this page.
chore(fleet): re-home the profile/skill tree to the armonissima vault; multi-root skill validation - #256
Closed
aarontrowbridge wants to merge 1 commit into
Closed
Conversation
…; multi-root skill validation The internal content half of the amico-plugin dissolution (the public half is PR #255): profiles/, gates/, and the internal skill library now live in the armonissima team vault (pushed as armonissima@3d78491); mount presence is the eligibility proof, same pattern as the retired plugin checkout. profile_verb: the shipped fleet presets compose BOTH tiers (researcher names amico-vault + hypothesis-review — public), and a single --skills-dir cannot name two roots. --skills-dir is now REPEATABLE; skill existence/surface is a union check across roots (first-hit wins, matching the library resolver); defaults = the vault skills dir + the extension's in-repo public library when resolvable from the installed bundle layout (bin/dist -> ../../skills). This lets the 12 long-skipped shipped-preset tests RUN for the first time (the old default root never existed on main) — they pass. Canonicity sweep: the mounts resolver + mount_store were ported from the Claude session-start hook; with the hook retired, the TS ports are the source of truth and the fixtures are the spec. profile_verb's lint-port comments re-point at the vault tree; lens_registry's deviation note resolves to "the design"; verbs/ledger_dispatch comments updated. Verified: amico-run suite 952 passed / 0 skipped (was 940 + 12 skips); extension suite 868 passed; typecheck clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The internal-content half of the amico-plugin dissolution (stacked on #255, the public half).
profiles/,gates/, and the 28 internal skills now live in the armonissima team vault (pushed asarmonissima@3d78491); mount presence is the eligibility proof — the same pattern as the retired plugin checkout, carried by the vault sync instead of a git clone.The real change: multi-root skill validation in
profile_verbThe shipped fleet presets compose both skill tiers — e.g.
researcherstagesamico-vault+hypothesis-review(public) alongside internal skills. A single--skills-dircannot name two roots, and the old default (~/harmoniqs/amico-plugin/profiles) never existed onmain, which is why the 12 shipped-preset tests were permanent skips.--skills-diris now repeatable; any explicit flag(s) replace the defaults.surface:is a union check across roots, first-hit wins (matching the library resolver).skills/+ the extension's in-repo public library when resolvable from the installed bundle layout (bin/dist/amico.js→../../skills); self-disables in dev/CI.Result: the 12 preset tests run for the first time and pass — amico-run suite is 952 passed / 0 skipped (was 940 + 12 skips).
Canonicity sweep
The mounts resolver (
amico-run/src/mounts.ts) andmount_store.tswere ported from the Claudesession-starthook with a "parity oracle" relationship. The hook is retired with the plugin repo — the TS ports are now declared canonical and the fixtures are the spec.profile_verb's lint-port comments re-point at the vault tree;lens_registry's deviation note resolves to "the design";verbs.ts/ledger_dispatch.tscomments updated.Verification
researcher,experimenter,engineer,librarian-insight,dreamer,default) resolve in both dispatch and spool-up modes against the two-root union.Follow-ups
wip/fleet-profileson amico-plugin should die unmerged — its content landed in the vault.amicorepo.