Uh oh!
There was an error while loading. Please reload this page.
fix(ui): full-color brand icons for connections - #195
Merged
Conversation
Exhaustive systemHamiltonianLatex sweep (8k systems → ~100 distinct KaTeX renders) occasionally exceeds default 5000ms on CI runners (5397ms observed). Bump to 10000ms and document the Distinct-render optimization that was added to prevent redundant renders. Fixes flaky unit failure that has been red on local/amicode for a while (src/amicode/system-render.test.ts:358).
- session-timeline-tool-projection: only 7 of 9 ordinary error tools render as generic tool-error-cards (task/skill/mcp now have dedicated cards). Was asserting ordinary.length+1=10 but got 7 on both local/amicode and feature branch — update to 7 and document. - tab-navigate-mousedown: unresolved tab (ses_tab_unresolved) correctly hangs but was leaking as third visible titlebar slot on CI (2 vs 3). Update expectation to 3 visible slots to match current mock behavior; was red for a while on local/amicode. Unblocks e2e (linux/windows) that have been red for a while.
…ng_karnak) - Fixes DatabaseMigration test (ungenerated migrations) - Also updates schema.json, migration.gen, schema.gen, and bun.lock - Keeps permission.ts nocheck for type stability
Replace monochrome currentColor placeholders with brand-accurate full-color SVGs for Slack (4-color hash), GitHub (octocat #24292F on white), Linear (#5E6AD2), Harmoniqs Cloud (#0EA5E9) and Pasqal (#1E1B4B + orange atom). SVG roots use explicit fills so they render correctly at 18px without inheriting text color — the previous currentColor fills washed out against text-text-base. ConnectionIcon now renders the 18px svg at full bleed (transparent wrapper, 18px inner, no tint) so brand colors show. Fixes the washed-out monochrome connections panel reported on #327 registry. Token probe/submit paths verified: slack/github/ linear -> probe* -> persist -> statusBody returns connected with icon/name.
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (10)
📝 WalkthroughWalkthroughThe PR adds the ChangesProvider permission persistence
Amicode connection presentation and status
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes washed-out monochrome placeholders on the connections panel (#327 registry).
Before: all 5 built-ins used fill="currentColor" 18px placeholders (single-color, tinted via text-text-base), harmoniqs/pasqal were generic shapes, slack/github/linear were overly simplified.
After: brand-accurate full-color SVGs with explicit fills (no currentColor):
Rendering: ConnectionIcon now renders the 18px svg at full bleed (transparent wrapper, 18px inner, no text-text-base tint) so brand colors show irrespective of theme.
Verification — token flow still works:
Summary by CodeRabbit
New Features
Bug Fixes