Uh oh!
There was an error while loading. Please reload this page.
feat(schema): add default field to question tool for pre-filled text inputs - #232
Merged
Merged
Conversation
…inputs Adds an optional `default` string field to the question schema (both V1 and V2). When set on a kind:"text" question, the UI pre-fills the text input with the value so the user can edit before submitting. Wired through: schema → tool description → App (session-question-dock) → TUI (question.tsx) → regenerated SDK types.
Uh oh!
There was an error while loading. Please reload this page.
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
📝 WalkthroughWalkthroughQuestion schemas now support optional editable defaults. The question tool preserves these values, and app and TUI session inputs use them when initializing custom answers. ChangesQuestion default values
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional
defaultstring field to the question schema (both V1 and V2). When set on akind: "text"question, the UI pre-fills the text input with the value so the user can edit before submitting.Changes
packages/schema/src/question.ts+v1/question.ts): addeddefault?: stringto the question base structpackages/core/src/tool/question.ts): documents the new field for the LLMsession-question-dock.tsx): seedsstore.customfrom question defaults on mountquestion.tsx): same seeding patterntypes.gen.ts): regenerated withdefault?: stringonQuestionInfoVerification
Motivation
The onboarding interview needs to present an auto-generated user description for confirmation/edit — the user should see it pre-filled and be able to modify before submitting.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation