Uh oh!
There was an error while loading. Please reload this page.
fix(registry): stop dropping the first native arg on NoId commands, and disambiguate optional-id vs. passthrough args after "--" (#159) - #163
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
buildCtx's HasArgs/BuiltinFlags.Set logic decided whether to strip args[0] (assuming it was a leftover ) by re-checking vspec.RequiresId || vspec.AllowsId, instead of tracking whether an id was actually assigned. This caused two bugs:
Fix: introduce consumedIdArg, set to true only at the exact point ctx.Id is actually assigned from args[0], and use it (instead of re-deriving the condition) for the downstream stripping logic. For the optional-id branch, resolve the ambiguity with cmd.Flags().ArgsLenAtDash() — the id is only real if it precedes a literal -- (or there's no -- at all); if -- is the very first token, nothing was given as an id, regardless of how many flags preceded it.
Fixes#159