Uh oh!
There was an error while loading. Please reload this page.
Conversation
certik
commented
May 15, 2015
MemberAuthor
I see, I should check first that the file exists, perhaps only do this on OS X 10.10 (previous versions do not have this problem). |
certik
commented
May 15, 2015
MemberAuthor
Done, it now tests if the file exists. I think that is sufficient, if the file exists but doesn't have the bug, it will just copy it, which should be safe. |
certik
commented
May 15, 2015
MemberAuthor
It still works on my OS X. |
This was referenced May 15, 2015
Closed
jcftang
commented
May 16, 2015
Member
+1 looks good to me |
certik
commented
May 16, 2015
MemberAuthor
Thanks for the review, this PR is essential for OS X. |
certik added a commit
that referenced
this pull request
May 16, 2015
gcc: install fixed dispatch/object.h header file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#742.
I tested this, it is ready for review.