Skip to content

Add traffic endpoints. - #380

Open
ajmcmiddlin wants to merge 18 commits into
haskell-github:masterfrom
qfpl:traffic
Open

Add traffic endpoints.#380
ajmcmiddlin wants to merge 18 commits into
haskell-github:masterfrom
qfpl:traffic

Conversation

@ajmcmiddlin

@ajmcmiddlinajmcmiddlin commented Jun 3, 2019

Copy link
Copy Markdown

Add endpoints from the traffic API.

phadej
phadej suggested changes Jun 3, 2019
View reviewed changes
Comment threadsrc/GitHub/Data/Traffic.hs Outdated
Comment threadsrc/GitHub/Data/Traffic.hs Outdated
Comment threadsrc/GitHub/Endpoints/Repos/Traffic.hs
Comment threadsrc/GitHub/Data/Traffic.hs Outdated
@phadejphadej self-assigned this Jun 3, 2019
@ajmcmiddlin

ajmcmiddlin commented Jun 3, 2019

Copy link
Copy Markdown
Author

@phadej, thanks for the quick feedback. I think I've addressed everything as requested. Let me know what you want me to change the example repo to if you want it changed.

phadej
phadej reviewed Jun 4, 2019
View reviewed changes
Comment threadsrc/GitHub/Endpoints/Repos/Traffic.hs Outdated
@ajmcmiddlinajmcmiddlin mentioned this pull request Jun 6, 2019
Closed
@ajmcmiddlin

ajmcmiddlin commented Jun 9, 2019

Copy link
Copy Markdown
Author

@phadej I believe I've addressed the outstanding feedback. Let me know if I haven't.

@andreasabel

andreasabel commented Apr 19, 2022

Copy link
Copy Markdown
Member

@Mergifyio rebase

@mergify

mergifyBot commented Apr 19, 2022

Copy link
Copy Markdown

rebase

❌ Base branch update has failed

Details

No oauth valid tokens
err-code: 287BC

andreasabel
andreasabel requested changes Apr 19, 2022
View reviewed changes

@andreasabelandreasabel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ajmcmiddlin for this contribution!
Can we have a testcase, or a demonstration in samples/?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreasabelandreasabelandreasabel requested changes
+1 more reviewer
@phadejphadejphadej requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

@phadejphadej

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ajmcmiddlin@andreasabel@phadej