Skip to content

Add support for GHC 9.6 and GHC 9.8 - #130

Merged
Mikolaj merged 11 commits into
haskell:masterfrom
TeofilC:wip/ghc-9.8
Nov 5, 2024
Merged

Add support for GHC 9.6 and GHC 9.8#130
Mikolaj merged 11 commits into
haskell:masterfrom
TeofilC:wip/ghc-9.8

Conversation

@TeofilC

Copy link
Copy Markdown
Member

This build upon #129 to add support for 9.6 and 9.8 as well.

@TeofilC

TeofilC commented Mar 1, 2024

Copy link
Copy Markdown
MemberAuthor

The GHC 9.8 support is blocked on:

The rest looks fine. Do note that the mtl bump requires a code change so not all of this is just bounds stuff

@TeofilC
TeofilC marked this pull request as ready for review March 1, 2024 11:32
@TeofilC
TeofilCforce-pushed the wip/ghc-9.8 branch 2 times, most recently from c8d6bf1 to 8846508CompareMarch 1, 2024 12:05
@TeofilC

Copy link
Copy Markdown
MemberAuthor

This should be good now. I don't have the permissions I think to rerun CI

@Mikolaj

Copy link
Copy Markdown
Member

Me neither. Could you maybe rebase and push?

@TeofilC

Copy link
Copy Markdown
MemberAuthor

I've pushed an empty commit and I'll drop it once CI has run, since this is already up-to-date with master

@TeofilC

Copy link
Copy Markdown
MemberAuthor

Huh I guess Windows and Mac are broken? They seem to lack the C libs

@TeofilC
TeofilCforce-pushed the wip/ghc-9.8 branch 2 times, most recently from ab51e52 to dc2e3e3CompareNovember 1, 2024 16:09
@TeofilC

Copy link
Copy Markdown
MemberAuthor

I've managed to get one of the MacOS jobs to pass at least but no luck with the rest.

Could we merge this @Mikolaj and handle the rest later?

Btw if you need a hand maintaining this repo and ghc-events, I'd be happy to help.

@Mikolaj

Copy link
Copy Markdown
Member

Could we merge this @Mikolaj and handle the rest later?

Makes sense. Anybody: any objections?

Btw if you need a hand maintaining this repo and ghc-events, I'd be happy to help.

Oh, that would be great. I'm not the maintainer myself, I'm merely helping @maoe, who is currently busy, while the real maintainer, as you can see in the .cabal file, is @simonmar, whom I'd normally ask to extend the Hackage maintainers list on Hackage for Threadscope and ghc-events and to give any extra github permissions.

@Mikolaj

Copy link
Copy Markdown
Member

I've heard no objections, so let me merge.

@Mikolaj
Mikolaj merged commit eff3833 into haskell:masterNov 5, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@TeofilC@Mikolaj@hellwolf