Uh oh!
There was an error while loading. Please reload this page.
Option to encode single-constructor types as tagged sums - #522
Conversation
bergmark
commented
Mar 19, 2017
Github showed the already merged PR's in the history so i force pushed a rebase. |
bergmark
commented
Mar 19, 2017
Thanks again, This looks good as well! Unavoidably this is a breaking change due to the I'll cut a release with the other PR's tomorrow and then merge this. |
bergmark
commented
Mar 19, 2017
Looks like i also confused myself and travis by doing "git push origin Lysxia/feature-474" so don't mind the test failure! |
bergmark
commented
Mar 19, 2017
I noticed that the new field needs to be added to the |
bergmark
commented
Mar 19, 2017
#526 was merged so this can be rebased. |
5cb6d6d to
6674f53Comparebergmark
commented
Mar 21, 2017
Same here, I didn't get notified of the recent changes. Thanks a lot for this! |
Lysxia
commented
Mar 21, 2017
Okay! You're welcome! Actually this patch may lead to some serious regressions because I've introduced an actual loop in the generic implementation. We can probably avoid it by tracking the new option at the type level, as a parameter of the |
Lysxia
commented
Apr 3, 2017
This is now just two simple overlapping instances instead of the previous recursive mess. Ready to merge. |
bergmark
commented
Apr 7, 2017
Great stuff! |
As suggested in #206 and possibly #473