Uh oh!
There was an error while loading. Please reload this page.
Add cabal.bench.project for running benchmarks - #772
Merged
Conversation
bergmark
reviewed
Apr 5, 2020
Uh oh!
There was an error while loading. Please reload this page.
bergmark
reviewed
Apr 5, 2020
Uh oh!
There was an error while loading. Please reload this page.
phadejforce-pushed
the
benchmarks-running
branch
2 times, most recently
from
April 6, 2020 15:42
10ac2de to
95a9e4eComparephadej
commented
Apr 7, 2020
CollaboratorAuthor
The CI is green now. So next I'll refactor the benchmarks a bit. |
phadej
marked this pull request as ready for review
April 11, 2020 12:10
phadejforce-pushed
the
benchmarks-running
branch
7 times, most recently
from
April 12, 2020 10:25
0b5b6ff to
dd9a7dfCompareUh oh!
There was an error while loading. Please reload this page.
bergmark
commented
Apr 13, 2020
Collaborator
Looks like we need base-compat-batteries for the benchmarks as well |
- bench.sh is the runner and comparator for benchmarks we have. - The idea is to migrate all benchmarks we have into `aeson-benchmark-suite` - I added `criterion-compare-txt` to output textual tables, these are easier to copy into pull request etc. - Added GitHub issues example, we still need more.
phadej
commented
Apr 13, 2020
CollaboratorAuthor
CI green (finally). Please give it through review. I'd like to merge what one has here before adding more decode (and encode) cases and refactoring the existing benchmarks to be part of the suite. |
bergmark
commented
Apr 15, 2020
Collaborator
LG! Tested it out, easy to use by just reading CONTRIBUTING. Very nice to avoid the recompilations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.