Skip to content

'Setup.hs sdist': invoke 'tar' with '--format ustar' if possible. - #1903

Merged
23Skidoo merged 1 commit into
haskell:masterfrom
23Skidoo:issue-1901
Sep 25, 2014
Merged

'Setup.hs sdist': invoke 'tar' with '--format ustar' if possible.#1903
23Skidoo merged 1 commit into
haskell:masterfrom
23Skidoo:issue-1901

Conversation

@23Skidoo

@23Skidoo23Skidoo commented May 26, 2014

Copy link
Copy Markdown
Member

Fixes#1901. Some variants of tar don't support the --format option, so we have to do feature detection.

Note that 'cabal sdist' (as opposed to Setup.hs sdist) uses the built-in tar.gz archiver (Distribution.Client.Tar) and doesn't invoke tar or gzip.

@dcoutts

dcoutts commented Jun 21, 2014

Copy link
Copy Markdown
Contributor

Yep looks ok.

In general, for this kind of feature detection I think it makes sense to put it in the configure step of the program, and to save the result in that key/value store we've got in the configured program.

In this case it doesn't make a difference for performance, though it might be nice to be vaguely consistent about how we do feature detection.

@23Skidoo

23Skidoo commented Jun 21, 2014

Copy link
Copy Markdown
MemberAuthor

I'll do that change and then commit.

@23Skidoo
'Setup.hs sdist': invoke 'tar' with '--format ustar' if possible.
eaf2aae
Fixeshaskell#1901. Some variants of 'tar' don't support the '--format' option, so we
have to do feature detection.
Note that 'cabal sdist' (as opposed to 'Setup.hs sdist') uses the built-in
tar.gz archiver ('Distribution.Client.Tar') and doesn't invoke 'tar' or 'gzip'.
23Skidoo added a commit that referenced this pull request Sep 25, 2014
@23Skidoo
Merge pull request#1903from 23Skidoo/issue-1901
4be5096
'Setup.hs sdist': invoke 'tar' with '--format ustar' if possible.
@23Skidoo
23Skidoo merged commit 4be5096 into haskell:masterSep 25, 2014
@23Skidoo
23Skidoo deleted the issue-1901 branch September 25, 2014 21:47
philderbeast added a commit to cabalism/cabal that referenced this pull request Feb 21, 2026
@philderbeast
Fix typo --formar in changelog forhaskell#1903
29e2f7e
philderbeast added a commit to cabalism/cabal that referenced this pull request Feb 21, 2026
@philderbeast
Use separate config for typos for docs & srcs
a20e895
- Add .typos-hs.toml
- Use explicit --config with typos
- Fix typo --formar in changelog for haskell#1903
- Rename to .typos-srcs.toml
- Trigger ci run on push
philderbeast added a commit to cabalism/cabal that referenced this pull request Feb 24, 2026
@philderbeast
Use separate config for typos for docs & srcs
26a70f5
- Add .typos-hs.toml
- Use explicit --config with typos
- Fix typo --formar in changelog for haskell#1903
- Rename to .typos-srcs.toml
- Trigger ci run on push
philderbeast added a commit to cabalism/cabal that referenced this pull request Feb 25, 2026
@philderbeast
Use separate config for typos for docs & srcs
420287b
- Add .typos-hs.toml
- Use explicit --config with typos
- Fix typo --formar in changelog for haskell#1903
- Rename to .typos-srcs.toml
- Trigger ci run on push
philderbeast added a commit to cabalism/cabal that referenced this pull request Feb 25, 2026
@philderbeast
Use separate config for typos for docs & srcs
d7d9c57
- Add .typos-hs.toml
- Use explicit --config with typos
- Fix typo --formar in changelog for haskell#1903
- Rename to .typos-srcs.toml
- Trigger ci run on push
philderbeast added a commit to cabalism/cabal that referenced this pull request Feb 28, 2026
@philderbeast
Use separate config for typos for docs & srcs
26e5688
- Add .typos-hs.toml
- Use explicit --config with typos
- Fix typo --formar in changelog for haskell#1903
- Rename to .typos-srcs.toml
- Trigger ci run on push
philderbeast added a commit to cabalism/cabal that referenced this pull request Feb 28, 2026
@philderbeast
Use separate config for typos for docs & srcs
d2300d8
- Add .typos-hs.toml
- Use explicit --config with typos
- Fix typo --formar in changelog for haskell#1903
- Rename to .typos-srcs.toml
- Trigger ci run on push
philderbeast added a commit to cabalism/cabal that referenced this pull request Mar 1, 2026
@philderbeast
Use separate config for typos for docs & srcs
6ee6595
- Add .typos-hs.toml
- Use explicit --config with typos
- Fix typo --formar in changelog for haskell#1903
- Rename to .typos-srcs.toml
- Trigger ci run on push
philderbeast added a commit to cabalism/cabal that referenced this pull request Mar 1, 2026
@philderbeast
Use separate config for typos for docs & srcs
9c94c89
- Add .typos-hs.toml
- Use explicit --config with typos
- Fix typo --formar in changelog for haskell#1903
- Rename to .typos-srcs.toml
- Trigger ci run on push
philderbeast added a commit to cabalism/cabal that referenced this pull request Mar 2, 2026
@philderbeast
Use separate config for typos for docs & srcs
8039463
- Add .typos-hs.toml
- Use explicit --config with typos
- Fix typo --formar in changelog for haskell#1903
- Rename to .typos-srcs.toml
- Trigger ci run on push
philderbeast added a commit to cabalism/cabal that referenced this pull request Mar 2, 2026
@philderbeast
Add hs-typos .PHONY target
ff54088
- Configure typos for hs abbreviations and allowed misspellings
- Fix typo inherithed
- Fix typo succesfully
- Fix typo environmnet
- Fix typo ther
- Add more abbreviations and misspellings
- Fix typo uncessary
- Fix typo becuase
- Fix typo Uknown
- Remove false hits from dist-newstyle
- Add an hs-fix-typos .PHONY target
- Exclude non-existent files
- Exclude path dist-newstyle
- Do path exclusions one per line
- Add make hs-typos to typos workflow
- Fix typo ReportUserTargerNonexistantFile
- Rename files to all-test-suite.*
- Bump typo to v1.43.5
- Use separate config for typos for docs & srcs
- Add .typos-hs.toml
- Use explicit --config with typos
- Fix typo --formar in changelog for haskell#1903
- Rename to .typos-srcs.toml
- Trigger ci run on push
- Fix typo comparision
- Fix typo limt
- Fix typo appropiate
- Fix typo preprocesser
- Fix typo verstion
- Fix typo cylical
- Fix typo synopsys
- Add a changelog entry
- Exclude the changelog entry with a typo
philderbeast added a commit to cabalism/cabal that referenced this pull request Mar 3, 2026
@philderbeast
Add hs-typos .PHONY target
b4a28ea
- Configure typos for hs abbreviations and allowed misspellings
- Fix typo inherithed
- Fix typo succesfully
- Fix typo environmnet
- Fix typo ther
- Add more abbreviations and misspellings
- Fix typo uncessary
- Fix typo becuase
- Fix typo Uknown
- Remove false hits from dist-newstyle
- Add an hs-fix-typos .PHONY target
- Exclude non-existent files
- Exclude path dist-newstyle
- Do path exclusions one per line
- Add make hs-typos to typos workflow
- Fix typo ReportUserTargerNonexistantFile
- Rename files to all-test-suite.*
- Bump typo to v1.43.5
- Use separate config for typos for docs & srcs
- Add .typos-hs.toml
- Use explicit --config with typos
- Fix typo --formar in changelog for haskell#1903
- Rename to .typos-srcs.toml
- Trigger ci run on push
- Fix typo comparision
- Fix typo limt
- Fix typo appropiate
- Fix typo preprocesser
- Fix typo verstion
- Fix typo cylical
- Fix typo synopsys
- Add a changelog entry
- Exclude the changelog entry with a typo
Kleidukos pushed a commit to Kleidukos/cabal that referenced this pull request Mar 12, 2026
@philderbeast@Kleidukos
Add hs-typos .PHONY target
258bf72
- Configure typos for hs abbreviations and allowed misspellings
- Fix typo inherithed
- Fix typo succesfully
- Fix typo environmnet
- Fix typo ther
- Add more abbreviations and misspellings
- Fix typo uncessary
- Fix typo becuase
- Fix typo Uknown
- Remove false hits from dist-newstyle
- Add an hs-fix-typos .PHONY target
- Exclude non-existent files
- Exclude path dist-newstyle
- Do path exclusions one per line
- Add make hs-typos to typos workflow
- Fix typo ReportUserTargerNonexistantFile
- Rename files to all-test-suite.*
- Bump typo to v1.43.5
- Use separate config for typos for docs & srcs
- Add .typos-hs.toml
- Use explicit --config with typos
- Fix typo --formar in changelog for haskell#1903
- Rename to .typos-srcs.toml
- Trigger ci run on push
- Fix typo comparision
- Fix typo limt
- Fix typo appropiate
- Fix typo preprocesser
- Fix typo verstion
- Fix typo cylical
- Fix typo synopsys
- Add a changelog entry
- Exclude the changelog entry with a typo
zlonast pushed a commit to zlonast/cabal that referenced this pull request Mar 17, 2026
@philderbeast@zlonast
Add hs-typos .PHONY target
f660340
- Configure typos for hs abbreviations and allowed misspellings
- Fix typo inherithed
- Fix typo succesfully
- Fix typo environmnet
- Fix typo ther
- Add more abbreviations and misspellings
- Fix typo uncessary
- Fix typo becuase
- Fix typo Uknown
- Remove false hits from dist-newstyle
- Add an hs-fix-typos .PHONY target
- Exclude non-existent files
- Exclude path dist-newstyle
- Do path exclusions one per line
- Add make hs-typos to typos workflow
- Fix typo ReportUserTargerNonexistantFile
- Rename files to all-test-suite.*
- Bump typo to v1.43.5
- Use separate config for typos for docs & srcs
- Add .typos-hs.toml
- Use explicit --config with typos
- Fix typo --formar in changelog for haskell#1903
- Rename to .typos-srcs.toml
- Trigger ci run on push
- Fix typo comparision
- Fix typo limt
- Fix typo appropiate
- Fix typo preprocesser
- Fix typo verstion
- Fix typo cylical
- Fix typo synopsys
- Add a changelog entry
- Exclude the changelog entry with a typo
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

./Setup.hs sdist doesn't create tar archives in ustar format

2 participants

@23Skidoo@dcoutts