CI: add GHC 9.6.1 by ulysses4ever · Pull Request #8840 · haskell/cabal

ulysses4ever · 2023-03-12T15:35:53Z

Time to rock 🤘

Usual Blockers

Update our own bounds on things like base, unix, etc.
haskell/actions needs to support the new GHC.
Dependencies require allow-newer:
- rere Allow base-4.18 ulysses4ever/rere#20Allow transformers-0.6 ulysses4ever/rere#19
- cabal-plan Support base 4.18 (ships with GHC 9.6) haskell-hvr/cabal-plan#91
- windns
- Aeson and some of its deps. GHC 9.6 compatibility: bump ghc-prim and template-haskell upper bounds one notch aeson#1012
- tree-diff Support GHC-9.6.1 (including on Hackage) haskellari/tree-diff#71
As long as cabal versions are bumped (see Bump versions and deps on master branch to 3.11 and regenerate bootstrap files #8844 for this release), cabal-testsuite needs the latest release of cabal-install (more discussion: Default cabal.project in cabal repo fails with cabal-install older than latest release; hard to diagnose #8133).

Unusual Blockers

All install methods for cabal 3.8.1.0 failed actions#188 (fixed upstream)
cabal update is not run? actions#203 (fixed upstream)
Windows fails since 9.6 prerelease. Tracking: cabal-testsuite fails early on with linker error on Windows since GHC 9.6 #8858 and disable that combination (9.6.1@Win) for now.
*-suite validation fails on 9.6 altogether due to the mysterious "double directory" problem described in Hack around CI problems by sudo chown and disabling cache for Windows validate #8739. Disabling it for now.

TODO

create an issue for the "double directory" issue and make sure *-suite validation is reenabled after it's solved.
Bump minor versions of the previous computer series. Don't forget about GHC_FOR_RELEASE and the friends.

Mikolaj · 2023-03-13T14:37:27Z

@ulysses4ever: would perhaps bumping cabal on master to 3.11 help with this? If so, I can prioritize.

ulysses4ever · 2023-03-13T15:07:51Z

@Mikolaj oh it hasn't been? I think that's the reason of one of the failures, yes (number three in the "Usual blockers" list in OP). There's no rush though: do it when you feel it's the time. This PR can wait.

It seems that putting cache-restore in front did help with haskell/actions#203

Mikolaj · 2023-03-13T15:30:39Z

Version bumps on master: #8844

ulysses4ever · 2023-03-13T20:36:11Z

I rolled back cabal install in CI to 3.8 because on this branch the versions have not been updated and therefore cabal-testsuite requires 3.8. But I get a failure "All install methods for cabal 3.8.1.0 failed" foir some reason...:

https://github.com/haskell/cabal/actions/runs/4409245230/jobs/7725298762

It didn't happen with 3.10...

Mikolaj · 2023-03-13T21:05:16Z

This seems broken upstream. Let's see if it works fine (again with 3.10) once the version bump PR lands.

andreasabel

Great work, rock and roll!!

It seems like you accidentially but effectively turned of caching of ~/.cabal/store.

andreasabel · 2023-03-13T21:27:54Z

@ulysses4ever wrote:

But I get a failure "All install methods for cabal 3.8.1.0 failed" foir some reason...:

Well this is exactly haskell/actions#202, as analysed by @Mistuke: The setup action installs cabal 3.10.1.0 already with ghc, and then the subsequent attempt to install 3.8.1.0 chokes when trying to handle the 3.10.1.0 generated config file.

ulysses4ever · 2023-03-13T21:56:21Z

@andreasabel well, I must say: you put it much more clear than I was able to distill from that thread. Thank you!

I thought some sort of workaround had been deployed though? Mistuke said that it should be 3.8 now? I can try to explicitly rm the config perhaps.

ulysses4ever · 2023-03-13T22:02:21Z

Otherwise, thanks for the review! I'll look into actionlint.

Mikolaj · 2023-03-13T22:30:00Z

The master version bump PR is merged.

andreasabel · 2023-03-14T00:01:52Z

@ulysses4ever : I fixed the haskell setup action v2 now, based on the advice by @Mistuke. Please try again!

ulysses4ever · 2023-03-14T01:18:29Z

Oh no, why is it trying to build Cabal-syntax-3.8.1.0... https://github.com/haskell/cabal/actions/runs/4409245230/jobs/7728945807#step:13:788

Mikolaj · 2023-03-14T09:10:22Z

Oh no, why is it trying to build Cabal-syntax-3.8.1.0... https://github.com/haskell/cabal/actions/runs/4409245230/jobs/7728945807#step:13:788

How about rebasing on master (with the version bumps)?

ulysses4ever · 2023-03-14T12:52:01Z

How about rebasing on master (with the version bumps)?

Well, this is a good point and a possibility I had in mind. But I thought that moving one thing at a time (in this case, the version of GHC) may be easier. I can try to rebase, yes. I may not have time to for a day or two though.

Mikolaj · 2023-03-14T15:03:03Z

No rush. BTW, yet another possibility for the CI cache problem resolution may be to reset the whole cache (first only in the PR, to verify) and so switch to XDG completely. Then the result of cabal update is properly found and used.

ulysses4ever · 2023-03-15T02:44:46Z

All right, useless GitHub wouldn't run CI because of conflicts with master (TIL...), so I had to rebase on master and, therefore, pull the versions bump from #8844. Now let's see...

See comments.

andreasabel

Yes!!

ulysses4ever · 2023-04-02T05:48:09Z

@Mikolaj on the topic of bumping minor versions. Our GHC_FOR_RELEASE is currently at 9.2.3. Do you want me to bump it to 9.2.7 or leave the 9.2 series alone. We could also have two 9.2.x compilers, I presume.

Mikolaj · 2023-04-03T09:08:13Z

Yes, I think bumping it all makes sense and I'd keep only the newest version. I waited with touching the gitlab script until after the release, so this is a good moment now.

undo 6bd17fc from #8844; the change was made in response to an issue that was later fixed on the haskell/action side

haskell/acitons support prereleases since recently, and so, a separate workflow is not necessary.

It hasn't been used for a while now.

Partially revert 78cbeba.

ulysses4ever · 2023-04-05T15:26:38Z

@mergify backport 3.10

mergify · 2023-04-05T15:26:42Z

backport 3.10

✅ Backports have been created

Details

#8899 CI: add GHC 9.6.1 (backport #8840) has been created for branch 3.10

Mikolaj · 2023-04-05T17:41:12Z

Hurray!

ulysses4ever · 2023-04-05T17:44:16Z

Yep, this was a long ride. Not sure when I have energy to attend to a backport...

Backport of haskell#8840

Mikolaj added continuous-integration attention: needs-backport 3.12 labels Mar 13, 2023

ulysses4ever mentioned this pull request Mar 13, 2023
cabal update is not run? haskell/actions#203
Closed

Mikolaj mentioned this pull request Mar 13, 2023
Add support for loading multiple components into one repl session #8726
Merged
3 tasks

ulysses4ever mentioned this pull request Mar 13, 2023
Bump versions and deps on master branch to 3.11 and regenerate bootstrap files #8844
Merged

ulysses4ever force-pushed the ci-9.6.1 branch 2 times, most recently from c8a9dd7 to 28ff5e7Compare March 13, 2023 20:27

andreasabel requested changes Mar 13, 2023
View reviewed changes

Comment thread.github/workflows/validate.yml
Comment thread.github/workflows/validate.yml Outdated
Comment thread.github/workflows/validate.yml

Mikolaj mentioned this pull request Mar 13, 2023
Bump versions and deps on master branch to 3.11 and regenerate bootstrap files (backport #8844) #8847
Closed

ulysses4ever mentioned this pull request Mar 14, 2023
CI: disable prerelease validation #8852
Merged

ulysses4ever force-pushed the ci-9.6.1 branch 2 times, most recently from 3f8fa8c to d668620Compare March 15, 2023 02:11

haskell deleted a comment from mergifyBotMar 15, 2023

ulysses4ever force-pushed the ci-9.6.1 branch 2 times, most recently from ab06a99 to 1f8606cCompare March 15, 2023 02:42

ulysses4ever added 2 commits April 1, 2023 16:13

CI GHC 9.6: allow-newer base for rere (TODO: revert)
db4d518

CI GHC 9.6: have to disable *-suite validation (TODO: revert)
d04a881
See comments.

ulysses4ever force-pushed the ci-9.6.1 branch from 902e46b to 1075652Compare April 1, 2023 14:16

andreasabel approved these changes Apr 1, 2023
View reviewed changes

ulysses4ever added the merge me Tell Mergify Bot to merge label Apr 1, 2023

ulysses4ever force-pushed the ci-9.6.1 branch from fa426c1 to 1075652Compare April 1, 2023 20:05

ulysses4ever added 8 commits April 3, 2023 14:03

CI: add GHC 9.6.1 and bump minor versions on other series
7ce7b7a

CI: no need in chown for ghcup anymore
ea1ec57

CI: no need to exclude caching on Windows anymore
4f58355

CI: no need to restore cache before setup-haskell
3b8e6e9
undo 6bd17fc from #8844; the change was made in response to an issue that was later fixed on the haskell/action side

CI: remove separate prerelease workflow
bb10ae3
haskell/acitons support prereleases since recently, and so, a separate workflow is not necessary.

CI: cleanup the cache key
a68c07d

CI: remove the matrix.cli parameter
2e8a1e1
It hasn't been used for a while now.

After moving GHC 9.4.2->9.4.4 some broken Windows tests work
420ccd8
Partially revert 78cbeba.

ulysses4ever force-pushed the ci-9.6.1 branch from 911f854 to 420ccd8Compare April 3, 2023 12:03

mergifyBot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Apr 5, 2023

mergifyBot merged commit 6f9acee into masterApr 5, 2023

mergifyBot mentioned this pull request Apr 5, 2023
CI: add GHC 9.6.1 (backport #8840) #8899
Closed

Kleidukos added a commit to Kleidukos/cabal that referenced this pull request Apr 6, 2023
Add GHC 9.6 CI
6323c50
Backport of haskell#8840

Kleidukos added a commit to Kleidukos/cabal that referenced this pull request Apr 6, 2023
Add GHC 9.6 CI
545b4fe
Backport of haskell#8840

Kleidukos mentioned this pull request Apr 6, 2023
Add GHC 9.6 CI to the 3.10 branch #8901
Closed

Kleidukos added a commit to Kleidukos/cabal that referenced this pull request Apr 20, 2023
Add GHC 9.6 CI
2f9358d
Backport of haskell#8840

ulysses4ever deleted the ci-9.6.1 branch April 21, 2023 13:15

Mikolaj removed the attention: needs-backport 3.12 label Apr 8, 2024

Uh oh!

Conversation

ulysses4ever commented Mar 12, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mikolaj commented Mar 13, 2023

Uh oh!

ulysses4ever commented Mar 13, 2023

Uh oh!

Mikolaj commented Mar 13, 2023

Uh oh!

ulysses4ever commented Mar 13, 2023

Uh oh!

Mikolaj commented Mar 13, 2023

Uh oh!

andreasabel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

andreasabel commented Mar 13, 2023

Uh oh!

ulysses4ever commented Mar 13, 2023

Uh oh!

ulysses4ever commented Mar 13, 2023

Uh oh!

Mikolaj commented Mar 13, 2023

Uh oh!

andreasabel commented Mar 14, 2023

Uh oh!

ulysses4ever commented Mar 14, 2023

Uh oh!

Mikolaj commented Mar 14, 2023

Uh oh!

ulysses4ever commented Mar 14, 2023

Uh oh!

Mikolaj commented Mar 14, 2023

Uh oh!

ulysses4ever commented Mar 15, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andreasabel left a comment

Choose a reason for hiding this comment

Uh oh!

ulysses4ever commented Apr 2, 2023

Uh oh!

Mikolaj commented Apr 3, 2023

Uh oh!

ulysses4ever commented Apr 5, 2023

Uh oh!

mergifyBot commented Apr 5, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Mikolaj commented Apr 5, 2023

Uh oh!

ulysses4ever commented Apr 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ulysses4ever commented Mar 12, 2023•
edited
Loading

ulysses4ever commented Mar 15, 2023•
edited
Loading

mergifyBot commented Apr 5, 2023•
edited
Loading