Skip to content

Add getHostName - #621

Merged
kazu-yamamoto merged 1 commit into
haskell:masterfrom
pmiddend:add-hostname
Aug 18, 2026
Merged

Add getHostName#621
kazu-yamamoto merged 1 commit into
haskell:masterfrom
pmiddend:add-hostname

Conversation

@pmiddend

@pmiddendpmiddend commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Just a first draft of the getHostName feature taken from the hostname library with permission of the author.

@kazu-yamamoto
kazu-yamamoto self-requested a review August 18, 2026 07:04
@kazu-yamamoto

kazu-yamamoto commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

I ran CI. I will merge this if it passes.

@pmiddend

pmiddend commented Aug 18, 2026•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

I ran CI. I will merge this if it passes.

I'm currently building this on Windows and am getting a warning pertaining the use of stdcall on Win64. I am fixing this.

@pmiddend

pmiddend commented Aug 18, 2026

Copy link
Copy Markdown
ContributorAuthor

I ran CI. I will merge this if it passes.

I'm currently building this on Windows and am getting a warning pertaining the use of stdcall on Win64. I am fixing this.

Fixed! It builds fine on Windows and Linux it seems. Haven't tested OSX, we have to wait for CI to check that one. Thanks for the fast reply!

@pmiddend
pmiddend marked this pull request as ready for review August 18, 2026 07:37
@pmiddend

pmiddend commented Aug 18, 2026

Copy link
Copy Markdown
ContributorAuthor

I guess we also need a "since" marker and a changelog entry?

@kazu-yamamoto

kazu-yamamoto commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

I guess we also need a "since" marker and a changelog entry?

Right!

@pmiddend

pmiddend commented Aug 18, 2026

Copy link
Copy Markdown
ContributorAuthor

I guess we also need a "since" marker and a changelog entry?

Right!

Added it!

kazu-yamamoto
kazu-yamamoto approved these changes Aug 18, 2026
View reviewed changes

@kazu-yamamotokazu-yamamoto left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All green. LGTM

@kazu-yamamoto
kazu-yamamoto merged commit 63914c9 into haskell:masterAug 18, 2026
19 checks passed
@kazu-yamamoto

kazu-yamamoto commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

It has been merged.
Thank you.
I'm currently confirming the WinIO merge, so the release might be delayed.

@pmiddend

pmiddend commented Aug 18, 2026

Copy link
Copy Markdown
ContributorAuthor

It has been merged. Thank you. I'm currently confirming the WinIO merge, so the release might be delayed.

No problem, there's no urgency. Thanks for the quick review!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kazu-yamamotokazu-yamamotokazu-yamamoto approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pmiddend@kazu-yamamoto