Uh oh!
There was an error while loading. Please reload this page.
Update cabal + add wrapper over MWC - #225
Conversation
Shimuuar
left a comment
There was a problem hiding this comment.
There're few comments but otherwise it's good
No. Tests are not needed. It's just a wrapper and generator is tested in mwc-random
| import qualified Statistics.Distribution as D | ||
| import qualified Statistics.Distribution.Poisson.Internal as I | ||
| import Statistics.Internal | ||
| import Control.Monad (liftM) |
| instance D.ContGen PoissonDistribution where | ||
| genContVar (PD lambda) gen = fromIntegral <$> MWC.poisson lambda gen | ||
There was a problem hiding this comment.
Please drop ContGen instance. It is discrete distribution after all
There was a problem hiding this comment.
hi @Shimuuar , i am not able to drop ContGen:
class (DiscreteDistr d, ContGen d) => DiscreteGen d where
genDiscreteVar :: (StatefulGen g m) => d -> g -> m Int
statistics/Statistics/Distribution.hs
Line 168 in b628309
There was a problem hiding this comment.
Indeed! Sorry I forgot about it
daikonradish
commented
Jan 9, 2026
@Shimuuar , i have removed the unnecessary import. |
Uh oh!
There was an error while loading. Please reload this page.
Shimuuar
commented
Jan 9, 2026
Thank you. 0.16.5.0 is on hackage P.S. Generally it's better to make PR from branches other than master. No need to reset master branch afterwards |
Hi, do we need tests for this?