Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 145
Make primitive vectors nominally roled#316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -16,7 +16,10 @@ | ||
| `type role MVector nominal representational` (previously, both arguments | ||
| were `phantom`). | ||
| * The role signature for `Data.Vector.Primitive.Vector` is now | ||
| `type role Vector representational` (previously, it was `phantom`). | ||
| `type role Vector nominal` (previously, it was `phantom`). | ||
| The role signature for `Data.Vector.Primitive.Mutable.MVector` is now | ||
| `type role MVector nominal nominal` (previously, both arguments were | ||
| `phantom`). | ||
Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "for" -> "For" (or preferably put "The role signature for" before) | ||
| * The role signature for `Data.Vector.Storable.Vector` is now | ||
| `type role Vector nominal` (previous, it was `phantom`), and the signature | ||
| for `Data.Vector.Storable.Mutable.MVector` is now | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having conditional API is likely to make lifes of downstream dependencies more difficult. It may be better to export
unsafeCoerceVectorunconditionally and define it for old GHCs withoutCoercibleconstraint.