Uh oh!
There was an error while loading. Please reload this page.
Add some doctests - #363
Conversation
lehins
commented
Jan 24, 2021
Taking a quick peek at it looks great. One comment I have right now is that it is important to stay consistent with respect to doctests because users will mimic them in their code. In this case in particular I am talking about qualified imports. I've personally almost always used these: importqualifiedData.VectorasVimportqualifiedData.Vector.MutableasMVimportqualifiedData.Vector.GenericasVGimportqualifiedData.Vector.Generic.MutableasMVGimportqualifiedData.Vector.StorableasVSimportqualifiedData.Vector.Storable.MutableasMVSimportqualifiedData.Vector.PrimitiveasVPimportqualifiedData.Vector.Primitive.MutableasMVPimportqualifiedData.Vector.UnboxedasVUimportqualifiedData.Vector.Unboxed.MutableasMVUThose were also the names I've used in recently added PR #360 I am not terribly set on those names, but keeping them consistent I think is very important. However I really don't like the |
Shimuuar
commented
Jan 24, 2021
I always used G/V/P/U for qualified imports. But VG/V/VP/VU is just as good to me. I'll update doctests |
lehins
commented
Jan 26, 2021
@Shimuuar If you are busy I can update those qualified imports. I'd, like to merge this PR, just so I can included these doctests in the |
Examples are mostly copied from haskell#101
Shimuuar
commented
Jan 26, 2021
@lehins Done. |
lehins
commented
Jan 26, 2021
@Shimuuar Nice, thank you. I'll merge it when CI completes |
They're mostly copied from #101 with exception of maximum/minimum related ones (see #362, they're to be fixed separately). Also examples from accum & accumulate are converted to doctests