Uh oh!
There was an error while loading. Please reload this page.
Add inspection tests to vector - #389
Merged
Merged
Conversation
Bodigrim
approved these changes
May 23, 2021
Bodigrim
commented
May 23, 2021
Contributor
Fusion tests in Inspection testing relies on GHC plugins, and requires GHC 8.0. |
Shimuuar
commented
May 23, 2021
ContributorAuthor
@Bodigrim thanks for the input |
Inspection tests placed in separate test suite since vector-tests are built with both -O0 and -O2 optimization level and O-0 will break inspection tests.
It's just simplest function possible.
Shimuuar
commented
May 24, 2021
ContributorAuthor
I want to have working inspection tests for iso-deriving PR (#378) so I'm merging this one. Proper tests should be left for another PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At this point its mostly skeleton with single test. At the moment I'm a bit at loss what to add. Maybe copy tests from text?
Tests are placed into separate test suite because common test suite is built with both
-O0and-O2and former will break fusion.