Uh oh!
There was an error while loading. Please reload this page.
Improve documentation for mutable vectors - #404
Merged
Conversation
lehins
requested changes
Aug 13, 2021
lehins
left a comment
Contributor
There was a problem hiding this comment.
Thank you again for doing this work. Looks good overall, but a few minor changes.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
konsumlammforce-pushed
the
documentation-mutable
branch
from
August 14, 2021 17:47
4d1f1c4 to
8f91615Comparelehins
commented
Aug 15, 2021
Contributor
@konsumlamm Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #398.
This PR improves the doc comments for the mutable vector related modules (and a small fix in
Data.Vector.Primitive).Planned future work is to improve the docs for the fusion related modules and to add more complexity annotations to the (especially mutable vector) functions.