Uh oh!
There was an error while loading. Please reload this page.
doc: use BuildTheDocs, add CI workflow - #2
Conversation
39fef77 to
d952c3eCompareThere was a problem hiding this comment.
One of the biggest issues with the documentation on this fork is references to pip install hdlparse since I believe this will pull Kevin's repo and version 1.0.4. We'll have to make our repo's package available on PyPI. We can also consider changing the name of modules to pyhdlparse to prevent installation issues.
| > pip install setuptools | ||
| The easiest way to install pyHDLParser is from `PyPI <https://pypi.python.org/pypi/hdlparse>`_. |
There was a problem hiding this comment.
I assume one ticket of order is uploading a new package on PyPI. We should also consider changing the module names from hdlparse to pyhdlparse.
There was a problem hiding this comment.
As commented below, I agree. However, we need to decide which namespace to use in PyPI, and modify the Symbolator dependencies accordingly.
Uh oh!
There was an error while loading. Please reload this page.
| You can access the Hdlparse Git repository from `Github | ||
| <https://github.com/kevinpt/hdlparse>`_. You can install direct from PyPI with the "pip" | ||
| command if you have it available. | ||
| You can access the Hdlparse Git repository from `Github <https://github.com/hdl/pyHDLParser>`_. |
There was a problem hiding this comment.
external URLs need 2x _ at the end.
There was a problem hiding this comment.
In fact, I did not review the rst syntax. I did:
- Add
.btd.yml, CI workflow and adaptconf.pyfor using the sphinx_btd_theme.- Remove sources for customising the previous theme (alabaster).
- Split the
index.rstinto multiple.rstfiles and use atoctreeto have the sidebar populated in the sphinx_btd_theme. - Add a
genindex.rstplaceholder and use it in the toctree. - Replace
kevinpt/hdlparsewithhdl/pyHDLParserandHdlparsewithpyHDLParser; but not the references to PyPI. - Break lines at max 120 chars.
The content of the README.rst is actually duplicated in the docs. We should probably remove most of the content from this file, and fix the syntax in getting.rst (see https://github.com/hdl/pyHDLParser/pull/2/files#diff-d6d6b4e691a98ef7d987710f8d3aeeed8eafecfbdfe0b990ece4d2a9bf81a347R16).
umarcor
commented
Sep 24, 2021
@michael-etzkorn you are correct about the naming, pip, etc. I did not change that on purpose. Let me explain:
|
Store port line comments
Paebbels
commented
Nov 29, 2021
@umarcor converted this to a draft as it's not yet ready for review, right? |
This PR adds a CI workflow for building the docs and pushing to gh-pages automatically, using the BuildTheDocs Action and theme.