Fixed mod updates not fetching correct URL

[dreamsyntax]

Resolves#104

Tested on both Windows and Linux

• Verified Gamebanana updates work as expected
• Verified GitHub updates work as expected

Note: This PR only fixes the broken update functionality. The 'check on startup' is still broken and is unrelated to this PR.

[thesupersonic16]

UpdateSourceGMI uses UpdateServer from mod.ini as the client's BaseAddress which expects the URL to end with a forward slash. You can see the issue you are having in the remarks section which matches with what you found in the linked issue.

Note that all characters after the right-most "/" in the base URI are excluded when combined with the message URI.

I am thinking a better solution could be removing the use of BaseAddress from the HttpClient by replacing it with a combine function such as Helpers.CombineURL(Uri, string)

As for the "Check for mod updates" option, there is no implementation to display the updates yet, so it isn't called.

[dreamsyntax]

I am thinking a better solution could be removing the use of BaseAddress from the HttpClient by replacing it with a combine function such as Helpers.CombineURL(Uri, string)

Sure, I will change to this and test.

Update:
Verified with new build on linux and windows going from the same source mod 0.4.4 to 1.0.0

[dreamsyntax]

Removing the use of BaseAddress

I changed to use the helper for cleaner implementation.
That said, does it make more sense to just updated the updateSource itself, maybe in the constructor?

ex for:

publicUpdateSourceHMM(IMod mod,Uri baseURI){BaseURI=baseURI;Mod=mod;}

 public UpdateSourceHMM(IMod mod, Uri baseURI)
{
- BaseURI = baseURI;+ BaseURI = Helpers.EnsureEndsInSlash(baseURI); // would add `/` if not in mod ini (most mods dont have it), and do nothing otherwise
Mod = mod;
}

[thesupersonic16]

I don't think UpdateSourceHMM needs touching as that uses a different method of handling URL paths, althrough untested in your case.

Another solution could be just adding .TrimEnd('/') + '/' in ModGeneric to ensure all paths end with a slash to signify a base path which UpdateServer is meant to be, and this way UpdateSourceMulti will always get a path that is a directory which requires no other changes.

 var server = mainSection.Get("UpdateServer", string.Empty);
- if (Uri.TryCreate(server, UriKind.Absolute, out Uri? uri))+ if (Uri.TryCreate(server.TrimEnd('/') + '/', UriKind.Absolute, out Uri? uri))
{
Updater = new UpdateSourceMulti(this, uri);
}

Edit: You can also make that into a function in the helper class if you think this looks too confusing, simlar code is used in that class aswell.

[dreamsyntax]

I don't think UpdateSourceHMM needs touching as that uses a different method of handling URL paths, althrough untested in your case.

Correct, in the above I mistakenly referenced the wrong file. Per the actual changes it would be in GMI.

I think I like the ModGeneric solution personally. I'll change to that and test.

[dreamsyntax]

ModGeneric solution works as expected 👍
I prefer it, if it looks good to you.

[thesupersonic16]

Aside from the function name, I think this PR looks good. Please change the name to something that is less mis-leading to those who don't check the function description.

[dreamsyntax]

Resolves#104

Tested on both Windows and Linux

• Verified Gamebanana updates work as expected
• Verified GitHub updates work as expected

Note: This PR only fixes the broken update functionality. The 'check on startup' is still broken and is unrelated to this PR.

[thesupersonic16]

UpdateSourceGMI uses UpdateServer from mod.ini as the client's BaseAddress which expects the URL to end with a forward slash. You can see the issue you are having in the remarks section which matches with what you found in the linked issue.

Note that all characters after the right-most "/" in the base URI are excluded when combined with the message URI.

I am thinking a better solution could be removing the use of BaseAddress from the HttpClient by replacing it with a combine function such as Helpers.CombineURL(Uri, string)

As for the "Check for mod updates" option, there is no implementation to display the updates yet, so it isn't called.

[dreamsyntax]

I am thinking a better solution could be removing the use of BaseAddress from the HttpClient by replacing it with a combine function such as Helpers.CombineURL(Uri, string)

Sure, I will change to this and test.

Update:
Verified with new build on linux and windows going from the same source mod 0.4.4 to 1.0.0

[dreamsyntax]

Removing the use of BaseAddress

I changed to use the helper for cleaner implementation.
That said, does it make more sense to just updated the updateSource itself, maybe in the constructor?

ex for:

publicUpdateSourceHMM(IMod mod,Uri baseURI){BaseURI=baseURI;Mod=mod;}

 public UpdateSourceHMM(IMod mod, Uri baseURI)
{
- BaseURI = baseURI;+ BaseURI = Helpers.EnsureEndsInSlash(baseURI); // would add `/` if not in mod ini (most mods dont have it), and do nothing otherwise
Mod = mod;
}

[thesupersonic16]

I don't think UpdateSourceHMM needs touching as that uses a different method of handling URL paths, althrough untested in your case.

Another solution could be just adding .TrimEnd('/') + '/' in ModGeneric to ensure all paths end with a slash to signify a base path which UpdateServer is meant to be, and this way UpdateSourceMulti will always get a path that is a directory which requires no other changes.

 var server = mainSection.Get("UpdateServer", string.Empty);
- if (Uri.TryCreate(server, UriKind.Absolute, out Uri? uri))+ if (Uri.TryCreate(server.TrimEnd('/') + '/', UriKind.Absolute, out Uri? uri))
{
Updater = new UpdateSourceMulti(this, uri);
}

Edit: You can also make that into a function in the helper class if you think this looks too confusing, simlar code is used in that class aswell.

[dreamsyntax]

I don't think UpdateSourceHMM needs touching as that uses a different method of handling URL paths, althrough untested in your case.

Correct, in the above I mistakenly referenced the wrong file. Per the actual changes it would be in GMI.

I think I like the ModGeneric solution personally. I'll change to that and test.

[dreamsyntax]

ModGeneric solution works as expected 👍
I prefer it, if it looks good to you.

[thesupersonic16]

Aside from the function name, I think this PR looks good. Please change the name to something that is less mis-leading to those who don't check the function description.

[dreamsyntax]

Resolves#104

Tested on both Windows and Linux

• Verified Gamebanana updates work as expected
• Verified GitHub updates work as expected

Note: This PR only fixes the broken update functionality. The 'check on startup' is still broken and is unrelated to this PR.

[thesupersonic16]

UpdateSourceGMI uses UpdateServer from mod.ini as the client's BaseAddress which expects the URL to end with a forward slash. You can see the issue you are having in the remarks section which matches with what you found in the linked issue.

Note that all characters after the right-most "/" in the base URI are excluded when combined with the message URI.

I am thinking a better solution could be removing the use of BaseAddress from the HttpClient by replacing it with a combine function such as Helpers.CombineURL(Uri, string)

As for the "Check for mod updates" option, there is no implementation to display the updates yet, so it isn't called.

[dreamsyntax]

I am thinking a better solution could be removing the use of BaseAddress from the HttpClient by replacing it with a combine function such as Helpers.CombineURL(Uri, string)

Sure, I will change to this and test.

Update:
Verified with new build on linux and windows going from the same source mod 0.4.4 to 1.0.0

[dreamsyntax]

Removing the use of BaseAddress

I changed to use the helper for cleaner implementation.
That said, does it make more sense to just updated the updateSource itself, maybe in the constructor?

ex for:

publicUpdateSourceHMM(IMod mod,Uri baseURI){BaseURI=baseURI;Mod=mod;}

 public UpdateSourceHMM(IMod mod, Uri baseURI)
{
- BaseURI = baseURI;+ BaseURI = Helpers.EnsureEndsInSlash(baseURI); // would add `/` if not in mod ini (most mods dont have it), and do nothing otherwise
Mod = mod;
}

[thesupersonic16]

I don't think UpdateSourceHMM needs touching as that uses a different method of handling URL paths, althrough untested in your case.

Another solution could be just adding .TrimEnd('/') + '/' in ModGeneric to ensure all paths end with a slash to signify a base path which UpdateServer is meant to be, and this way UpdateSourceMulti will always get a path that is a directory which requires no other changes.

 var server = mainSection.Get("UpdateServer", string.Empty);
- if (Uri.TryCreate(server, UriKind.Absolute, out Uri? uri))+ if (Uri.TryCreate(server.TrimEnd('/') + '/', UriKind.Absolute, out Uri? uri))
{
Updater = new UpdateSourceMulti(this, uri);
}

Edit: You can also make that into a function in the helper class if you think this looks too confusing, simlar code is used in that class aswell.

[dreamsyntax]

I don't think UpdateSourceHMM needs touching as that uses a different method of handling URL paths, althrough untested in your case.

Correct, in the above I mistakenly referenced the wrong file. Per the actual changes it would be in GMI.

I think I like the ModGeneric solution personally. I'll change to that and test.

[dreamsyntax]

ModGeneric solution works as expected 👍
I prefer it, if it looks good to you.

[thesupersonic16]

Aside from the function name, I think this PR looks good. Please change the name to something that is less mis-leading to those who don't check the function description.

[dreamsyntax]

Resolves#104

Tested on both Windows and Linux

• Verified Gamebanana updates work as expected
• Verified GitHub updates work as expected

Note: This PR only fixes the broken update functionality. The 'check on startup' is still broken and is unrelated to this PR.

[thesupersonic16]

UpdateSourceGMI uses UpdateServer from mod.ini as the client's BaseAddress which expects the URL to end with a forward slash. You can see the issue you are having in the remarks section which matches with what you found in the linked issue.

Note that all characters after the right-most "/" in the base URI are excluded when combined with the message URI.

I am thinking a better solution could be removing the use of BaseAddress from the HttpClient by replacing it with a combine function such as Helpers.CombineURL(Uri, string)

As for the "Check for mod updates" option, there is no implementation to display the updates yet, so it isn't called.

[dreamsyntax]

I am thinking a better solution could be removing the use of BaseAddress from the HttpClient by replacing it with a combine function such as Helpers.CombineURL(Uri, string)

Sure, I will change to this and test.

Update:
Verified with new build on linux and windows going from the same source mod 0.4.4 to 1.0.0

[dreamsyntax]

Removing the use of BaseAddress

I changed to use the helper for cleaner implementation.
That said, does it make more sense to just updated the updateSource itself, maybe in the constructor?

ex for:

publicUpdateSourceHMM(IMod mod,Uri baseURI){BaseURI=baseURI;Mod=mod;}

 public UpdateSourceHMM(IMod mod, Uri baseURI)
{
- BaseURI = baseURI;+ BaseURI = Helpers.EnsureEndsInSlash(baseURI); // would add `/` if not in mod ini (most mods dont have it), and do nothing otherwise
Mod = mod;
}

[thesupersonic16]

I don't think UpdateSourceHMM needs touching as that uses a different method of handling URL paths, althrough untested in your case.

Another solution could be just adding .TrimEnd('/') + '/' in ModGeneric to ensure all paths end with a slash to signify a base path which UpdateServer is meant to be, and this way UpdateSourceMulti will always get a path that is a directory which requires no other changes.

 var server = mainSection.Get("UpdateServer", string.Empty);
- if (Uri.TryCreate(server, UriKind.Absolute, out Uri? uri))+ if (Uri.TryCreate(server.TrimEnd('/') + '/', UriKind.Absolute, out Uri? uri))
{
Updater = new UpdateSourceMulti(this, uri);
}

Edit: You can also make that into a function in the helper class if you think this looks too confusing, simlar code is used in that class aswell.

[dreamsyntax]

I don't think UpdateSourceHMM needs touching as that uses a different method of handling URL paths, althrough untested in your case.

Correct, in the above I mistakenly referenced the wrong file. Per the actual changes it would be in GMI.

I think I like the ModGeneric solution personally. I'll change to that and test.

[dreamsyntax]

ModGeneric solution works as expected 👍
I prefer it, if it looks good to you.

[thesupersonic16]

Aside from the function name, I think this PR looks good. Please change the name to something that is less mis-leading to those who don't check the function description.

[dreamsyntax]

Resolves#104

Tested on both Windows and Linux

• Verified Gamebanana updates work as expected
• Verified GitHub updates work as expected

Note: This PR only fixes the broken update functionality. The 'check on startup' is still broken and is unrelated to this PR.

[thesupersonic16]

UpdateSourceGMI uses UpdateServer from mod.ini as the client's BaseAddress which expects the URL to end with a forward slash. You can see the issue you are having in the remarks section which matches with what you found in the linked issue.

Note that all characters after the right-most "/" in the base URI are excluded when combined with the message URI.

I am thinking a better solution could be removing the use of BaseAddress from the HttpClient by replacing it with a combine function such as Helpers.CombineURL(Uri, string)

As for the "Check for mod updates" option, there is no implementation to display the updates yet, so it isn't called.

[dreamsyntax]

I am thinking a better solution could be removing the use of BaseAddress from the HttpClient by replacing it with a combine function such as Helpers.CombineURL(Uri, string)

Sure, I will change to this and test.

Update:
Verified with new build on linux and windows going from the same source mod 0.4.4 to 1.0.0

[dreamsyntax]

Removing the use of BaseAddress

I changed to use the helper for cleaner implementation.
That said, does it make more sense to just updated the updateSource itself, maybe in the constructor?

ex for:

publicUpdateSourceHMM(IMod mod,Uri baseURI){BaseURI=baseURI;Mod=mod;}

 public UpdateSourceHMM(IMod mod, Uri baseURI)
{
- BaseURI = baseURI;+ BaseURI = Helpers.EnsureEndsInSlash(baseURI); // would add `/` if not in mod ini (most mods dont have it), and do nothing otherwise
Mod = mod;
}

[thesupersonic16]

I don't think UpdateSourceHMM needs touching as that uses a different method of handling URL paths, althrough untested in your case.

Another solution could be just adding .TrimEnd('/') + '/' in ModGeneric to ensure all paths end with a slash to signify a base path which UpdateServer is meant to be, and this way UpdateSourceMulti will always get a path that is a directory which requires no other changes.

 var server = mainSection.Get("UpdateServer", string.Empty);
- if (Uri.TryCreate(server, UriKind.Absolute, out Uri? uri))+ if (Uri.TryCreate(server.TrimEnd('/') + '/', UriKind.Absolute, out Uri? uri))
{
Updater = new UpdateSourceMulti(this, uri);
}

Edit: You can also make that into a function in the helper class if you think this looks too confusing, simlar code is used in that class aswell.

[dreamsyntax]

I don't think UpdateSourceHMM needs touching as that uses a different method of handling URL paths, althrough untested in your case.

Correct, in the above I mistakenly referenced the wrong file. Per the actual changes it would be in GMI.

I think I like the ModGeneric solution personally. I'll change to that and test.

[dreamsyntax]

ModGeneric solution works as expected 👍
I prefer it, if it looks good to you.

[thesupersonic16]

Aside from the function name, I think this PR looks good. Please change the name to something that is less mis-leading to those who don't check the function description.

[dreamsyntax]

Resolves#104

Tested on both Windows and Linux

• Verified Gamebanana updates work as expected
• Verified GitHub updates work as expected

Note: This PR only fixes the broken update functionality. The 'check on startup' is still broken and is unrelated to this PR.

[thesupersonic16]

UpdateSourceGMI uses UpdateServer from mod.ini as the client's BaseAddress which expects the URL to end with a forward slash. You can see the issue you are having in the remarks section which matches with what you found in the linked issue.

Note that all characters after the right-most "/" in the base URI are excluded when combined with the message URI.

I am thinking a better solution could be removing the use of BaseAddress from the HttpClient by replacing it with a combine function such as Helpers.CombineURL(Uri, string)

As for the "Check for mod updates" option, there is no implementation to display the updates yet, so it isn't called.

[dreamsyntax]

I am thinking a better solution could be removing the use of BaseAddress from the HttpClient by replacing it with a combine function such as Helpers.CombineURL(Uri, string)

Sure, I will change to this and test.

Update:
Verified with new build on linux and windows going from the same source mod 0.4.4 to 1.0.0

[dreamsyntax]

Removing the use of BaseAddress

I changed to use the helper for cleaner implementation.
That said, does it make more sense to just updated the updateSource itself, maybe in the constructor?

ex for:

publicUpdateSourceHMM(IMod mod,Uri baseURI){BaseURI=baseURI;Mod=mod;}

 public UpdateSourceHMM(IMod mod, Uri baseURI)
{
- BaseURI = baseURI;+ BaseURI = Helpers.EnsureEndsInSlash(baseURI); // would add `/` if not in mod ini (most mods dont have it), and do nothing otherwise
Mod = mod;
}

[thesupersonic16]

I don't think UpdateSourceHMM needs touching as that uses a different method of handling URL paths, althrough untested in your case.

Another solution could be just adding .TrimEnd('/') + '/' in ModGeneric to ensure all paths end with a slash to signify a base path which UpdateServer is meant to be, and this way UpdateSourceMulti will always get a path that is a directory which requires no other changes.

 var server = mainSection.Get("UpdateServer", string.Empty);
- if (Uri.TryCreate(server, UriKind.Absolute, out Uri? uri))+ if (Uri.TryCreate(server.TrimEnd('/') + '/', UriKind.Absolute, out Uri? uri))
{
Updater = new UpdateSourceMulti(this, uri);
}

Edit: You can also make that into a function in the helper class if you think this looks too confusing, simlar code is used in that class aswell.

[dreamsyntax]

I don't think UpdateSourceHMM needs touching as that uses a different method of handling URL paths, althrough untested in your case.

Correct, in the above I mistakenly referenced the wrong file. Per the actual changes it would be in GMI.

I think I like the ModGeneric solution personally. I'll change to that and test.

[dreamsyntax]

ModGeneric solution works as expected 👍
I prefer it, if it looks good to you.

[thesupersonic16]

Aside from the function name, I think this PR looks good. Please change the name to something that is less mis-leading to those who don't check the function description.

[dreamsyntax]

Resolves#104

Tested on both Windows and Linux

• Verified Gamebanana updates work as expected
• Verified GitHub updates work as expected

Note: This PR only fixes the broken update functionality. The 'check on startup' is still broken and is unrelated to this PR.

[thesupersonic16]

UpdateSourceGMI uses UpdateServer from mod.ini as the client's BaseAddress which expects the URL to end with a forward slash. You can see the issue you are having in the remarks section which matches with what you found in the linked issue.

Note that all characters after the right-most "/" in the base URI are excluded when combined with the message URI.

I am thinking a better solution could be removing the use of BaseAddress from the HttpClient by replacing it with a combine function such as Helpers.CombineURL(Uri, string)

As for the "Check for mod updates" option, there is no implementation to display the updates yet, so it isn't called.

[dreamsyntax]

I am thinking a better solution could be removing the use of BaseAddress from the HttpClient by replacing it with a combine function such as Helpers.CombineURL(Uri, string)

Sure, I will change to this and test.

Update:
Verified with new build on linux and windows going from the same source mod 0.4.4 to 1.0.0

[dreamsyntax]

Removing the use of BaseAddress

I changed to use the helper for cleaner implementation.
That said, does it make more sense to just updated the updateSource itself, maybe in the constructor?

ex for:

publicUpdateSourceHMM(IMod mod,Uri baseURI){BaseURI=baseURI;Mod=mod;}

 public UpdateSourceHMM(IMod mod, Uri baseURI)
{
- BaseURI = baseURI;+ BaseURI = Helpers.EnsureEndsInSlash(baseURI); // would add `/` if not in mod ini (most mods dont have it), and do nothing otherwise
Mod = mod;
}

[thesupersonic16]

I don't think UpdateSourceHMM needs touching as that uses a different method of handling URL paths, althrough untested in your case.

Another solution could be just adding .TrimEnd('/') + '/' in ModGeneric to ensure all paths end with a slash to signify a base path which UpdateServer is meant to be, and this way UpdateSourceMulti will always get a path that is a directory which requires no other changes.

 var server = mainSection.Get("UpdateServer", string.Empty);
- if (Uri.TryCreate(server, UriKind.Absolute, out Uri? uri))+ if (Uri.TryCreate(server.TrimEnd('/') + '/', UriKind.Absolute, out Uri? uri))
{
Updater = new UpdateSourceMulti(this, uri);
}

Edit: You can also make that into a function in the helper class if you think this looks too confusing, simlar code is used in that class aswell.

[dreamsyntax]

I don't think UpdateSourceHMM needs touching as that uses a different method of handling URL paths, althrough untested in your case.

Correct, in the above I mistakenly referenced the wrong file. Per the actual changes it would be in GMI.

I think I like the ModGeneric solution personally. I'll change to that and test.

[dreamsyntax]

ModGeneric solution works as expected 👍
I prefer it, if it looks good to you.

[thesupersonic16]

Aside from the function name, I think this PR looks good. Please change the name to something that is less mis-leading to those who don't check the function description.

[dreamsyntax]

Resolves#104

Tested on both Windows and Linux

• Verified Gamebanana updates work as expected
• Verified GitHub updates work as expected

Note: This PR only fixes the broken update functionality. The 'check on startup' is still broken and is unrelated to this PR.

[thesupersonic16]

UpdateSourceGMI uses UpdateServer from mod.ini as the client's BaseAddress which expects the URL to end with a forward slash. You can see the issue you are having in the remarks section which matches with what you found in the linked issue.

Note that all characters after the right-most "/" in the base URI are excluded when combined with the message URI.

I am thinking a better solution could be removing the use of BaseAddress from the HttpClient by replacing it with a combine function such as Helpers.CombineURL(Uri, string)

As for the "Check for mod updates" option, there is no implementation to display the updates yet, so it isn't called.

[dreamsyntax]

I am thinking a better solution could be removing the use of BaseAddress from the HttpClient by replacing it with a combine function such as Helpers.CombineURL(Uri, string)

Sure, I will change to this and test.

Update:
Verified with new build on linux and windows going from the same source mod 0.4.4 to 1.0.0

[dreamsyntax]

Removing the use of BaseAddress

I changed to use the helper for cleaner implementation.
That said, does it make more sense to just updated the updateSource itself, maybe in the constructor?

ex for:

publicUpdateSourceHMM(IMod mod,Uri baseURI){BaseURI=baseURI;Mod=mod;}

 public UpdateSourceHMM(IMod mod, Uri baseURI)
{
- BaseURI = baseURI;+ BaseURI = Helpers.EnsureEndsInSlash(baseURI); // would add `/` if not in mod ini (most mods dont have it), and do nothing otherwise
Mod = mod;
}

[thesupersonic16]

I don't think UpdateSourceHMM needs touching as that uses a different method of handling URL paths, althrough untested in your case.

Another solution could be just adding .TrimEnd('/') + '/' in ModGeneric to ensure all paths end with a slash to signify a base path which UpdateServer is meant to be, and this way UpdateSourceMulti will always get a path that is a directory which requires no other changes.

 var server = mainSection.Get("UpdateServer", string.Empty);
- if (Uri.TryCreate(server, UriKind.Absolute, out Uri? uri))+ if (Uri.TryCreate(server.TrimEnd('/') + '/', UriKind.Absolute, out Uri? uri))
{
Updater = new UpdateSourceMulti(this, uri);
}

Edit: You can also make that into a function in the helper class if you think this looks too confusing, simlar code is used in that class aswell.

[dreamsyntax]

I don't think UpdateSourceHMM needs touching as that uses a different method of handling URL paths, althrough untested in your case.

Correct, in the above I mistakenly referenced the wrong file. Per the actual changes it would be in GMI.

I think I like the ModGeneric solution personally. I'll change to that and test.

[dreamsyntax]

ModGeneric solution works as expected 👍
I prefer it, if it looks good to you.

[thesupersonic16]

Aside from the function name, I think this PR looks good. Please change the name to something that is less mis-leading to those who don't check the function description.