Skip to content

Replace "codimd" with "hedgedoc" - #40

Merged
davidmehren merged 2 commits into
hedgedoc:masterfrom
mrdrogdrog:rename-to-hedgedoc
Dec 27, 2020
Merged

Replace "codimd" with "hedgedoc"#40
davidmehren merged 2 commits into
hedgedoc:masterfrom
mrdrogdrog:rename-to-hedgedoc

Conversation

@mrdrogdrog

@mrdrogdrogmrdrogdrog commented Nov 9, 2020

Copy link
Copy Markdown
Member

This PR renames the tool and changes (almost) every occurrence of the word "codimd" to "hedgedoc". See hedgedoc/hedgedoc#453 for more details.

@mrdrogdrogmrdrogdrog mentioned this pull request Nov 9, 2020
Merged
@mrdrogdrog

mrdrogdrog commented Nov 9, 2020

Copy link
Copy Markdown
MemberAuthor

This PR should be merged after hedgedoc/hedgedoc#453

@mrdrogdrogmrdrogdrog changed the title Rename everything from "codimd" to "hedgedoc"Replace "codimd" with "hedgedoc"Nov 10, 2020
SISheogorath
SISheogorath requested changes Nov 10, 2020
View reviewed changes

@SISheogorathSISheogorath left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to consider adding a compatibility layer? As this will break existing configs.

Comment threadREADME.md Outdated
@mrdrogdrogmrdrogdrog mentioned this pull request Nov 10, 2020
Closed
22 tasks
@mrdrogdrog

mrdrogdrog commented Nov 15, 2020

Copy link
Copy Markdown
MemberAuthor

A compatibility layer sounds good, but I'm don't want to mess with the bash.

@ErikMichelson

ErikMichelson commented Nov 15, 2020•
edited
Loading

Copy link
Copy Markdown
Member

Compatibility layer in terms of not renaming/symlinking the binary and defining the CMD_ environment variables as fallback?

@davidmehren

davidmehren commented Dec 15, 2020

Copy link
Copy Markdown
Member

@SISheogorath Are you fine with these changes?

SISheogorath
SISheogorath requested changes Dec 16, 2020
View reviewed changes

@SISheogorathSISheogorath left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We definitely need to adjust a few more things and move/migrate configs.

Comment threadREADME.md Outdated
Comment threadREADME.md Outdated
Comment threadbin/hedgedoc
@mrdrogdrog
Rename everything from "codimd" to "hedgedoc"
0ca422a
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
Correct project name
Add symlink
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
Rename codimd to hedgedoc
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
trigger CI
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
@mrdrogdrog
add migration
af26da7
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
@davidmehren
davidmehren merged commit a9f874d into hedgedoc:masterDec 27, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@piratepiratepirate approved these changes
@davidmehrendavidmehrendavidmehren approved these changes
@SISheogorathSISheogorathSISheogorath approved these changes
@ErikMichelsonErikMichelsonErikMichelson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mrdrogdrog@ErikMichelson@davidmehren@pirate@SISheogorath