Skip to content

Allow to set CAINFO blob for HTTPS proxy - #1721

Open
diachenko-mischa wants to merge 1 commit into
masterfrom
mdiachenko/HERESUP-80353-https-proxy-cainfo
Open

Allow to set CAINFO blob for HTTPS proxy#1721
diachenko-mischa wants to merge 1 commit into
masterfrom
mdiachenko/HERESUP-80353-https-proxy-cainfo

Conversation

@diachenko-mischa

Copy link
Copy Markdown
Contributor

CAINFO for the HTTPS proxy must be passed
as a specific parameter into easy_handle
instead of general CAINFO

Relates-To: HERESUP-80353

@codecov

codecovBot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.40%. Comparing base (6363d4f) to head (c1a83e9).

Additional details and impacted files

Impacted file tree graph

@@ Coverage Diff @@## master #1721 +/- ##
==========================================
+ Coverage 80.34% 80.40% +0.06% 
==========================================
Files 356 356 Lines 14295 14298 +3 Branches 1565 1565 ==========================================
+ Hits 11485 11496 +11 + Misses 2178 2173 -5 + Partials 632 629 -3 
Files with missing linesCoverage Δ
olp-cpp-sdk-core/src/http/NetworkProxySettings.cpp100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@diachenko-mischa
diachenko-mischaforce-pushed the mdiachenko/HERESUP-80353-https-proxy-cainfo branch from 75e597b to 255d259CompareAugust 13, 2026 08:29
*/
NetworkProxySettings& WithPassword(std::string password);

/**

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update copyrights header in changed files

CAINFO for the HTTPS proxy must be passed
as a specific parameter into easy_handle
instead of general CAINFO
Relates-To: HERESUP-80353
Signed-off-by: Mykhailo Diachenko <ext-mykhailo.z.diachenko@here.com>
@diachenko-mischa
diachenko-mischaforce-pushed the mdiachenko/HERESUP-80353-https-proxy-cainfo branch from 255d259 to c1a83e9CompareAugust 20, 2026 13:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@diachenko-mischa@rustam-gamidov-here