Skip to content

Add MtlsTokenProvider for mTLS authentication - #1722

Merged
rustam-gamidov-here merged 1 commit into
masterfrom
rga/finalise-mtls-poc-datasdk-105
Aug 25, 2026
Merged

Add MtlsTokenProvider for mTLS authentication#1722
rustam-gamidov-here merged 1 commit into
masterfrom
rga/finalise-mtls-poc-datasdk-105

Conversation

@rustam-gamidov-here

Copy link
Copy Markdown
Collaborator

Implementing auto refreshing in place not using AutoRefreshToken and TokenEndpoint for simplicity and because mtls endpoint has very simple list of arguments and some features implemented in client authentication may be not supported at the moment.

Relates-To: DATASDK-105

@rustam-gamidov-here
rustam-gamidov-hereforce-pushed the rga/finalise-mtls-poc-datasdk-105 branch from 834a1de to aa8dc80CompareAugust 21, 2026 07:18
@codecov

codecovBot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.48148% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.46%. Comparing base (6363d4f) to head (afeae6e).

Files with missing linesPatch %Lines
...p-cpp-sdk-authentication/src/MtlsTokenProvider.cpp82.72%8 Missing and 6 partials ⚠️
...dk-authentication/src/AuthenticationClientImpl.cpp85.11%3 Missing and 4 partials ⚠️
...ion/include/olp/authentication/MtlsTokenProvider.h60.00%2 Missing ⚠️
...pp-sdk-authentication/src/AuthenticationClient.cpp0.00%2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@ Coverage Diff @@## master #1722 +/- ##
==========================================
+ Coverage 80.34% 80.46% +0.12% 
==========================================
Files 356 358 +2 Lines 14295 14426 +131 Branches 1565 1581 +16 ==========================================
+ Hits 11485 11607 +122 - Misses 2178 2181 +3 - Partials 632 638 +6 
Files with missing linesCoverage Δ
.../include/olp/authentication/AuthenticationClient.h100.00% <ø> (ø)
...ion/include/olp/authentication/MtlsTokenProvider.h60.00% <60.00%> (ø)
...pp-sdk-authentication/src/AuthenticationClient.cpp94.29% <0.00%> (-5.71%)⬇️
...dk-authentication/src/AuthenticationClientImpl.cpp81.75% <85.11%> (+0.55%)⬆️
...p-cpp-sdk-authentication/src/MtlsTokenProvider.cpp82.72% <82.72%> (ø)

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rustam-gamidov-here
rustam-gamidov-hereforce-pushed the rga/finalise-mtls-poc-datasdk-105 branch 4 times, most recently from bbfe1d3 to 582e352CompareAugust 21, 2026 16:58
@rustam-gamidov-here
rustam-gamidov-here marked this pull request as ready for review August 21, 2026 17:18
Comment threadolp-cpp-sdk-authentication/src/AuthenticationClientImpl.cpp Outdated
@rustam-gamidov-here
rustam-gamidov-hereforce-pushed the rga/finalise-mtls-poc-datasdk-105 branch 2 times, most recently from 55607ac to 6ae3555CompareAugust 25, 2026 07:43
Implementing auto refreshing in place not using AutoRefreshToken and
TokenEndpoint for simplicity and because mtls endpoint has very
simple list of arguments and some features implemented in client
authentication may be not supported at the moment.
Relates-To: DATASDK-105
Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
@rustam-gamidov-here
rustam-gamidov-hereforce-pushed the rga/finalise-mtls-poc-datasdk-105 branch from 6ae3555 to afeae6eCompareAugust 25, 2026 08:19
@rustam-gamidov-here
rustam-gamidov-here merged commit 2ce7d25 into masterAug 25, 2026
28 checks passed
@rustam-gamidov-here
rustam-gamidov-here deleted the rga/finalise-mtls-poc-datasdk-105 branch August 25, 2026 12:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@rustam-gamidov-here@mykolamalik@andrey-kashcheev@khomenkd