Skip to content

Fix compile errors - #844

Open
here-mikelley wants to merge 6 commits into
masterfrom
here-mikelley-compile-fix-missing-include
Open

Fix compile errors#844
here-mikelley wants to merge 6 commits into
masterfrom
here-mikelley-compile-fix-missing-include

Conversation

@here-mikelley

Copy link
Copy Markdown

Add missing #include for std::any_of() and std::count_if()

Add missing #include <algorithm> for std::any_of() and std::count_if()
@codecov

codecovBot commented May 16, 2020

Copy link
Copy Markdown

Codecov Report

Merging #844 into master will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #844 +/- ##
======================================
Coverage 78.6% 78.7% ======================================
Files 292 292 Lines 9951 9951 ======================================
+ Hits 7824 7827 +3 + Misses 2127 2124 -3 
Impacted FilesCoverage Δ
...p-cpp-sdk-dataservice-read/src/ApiClientLookup.cpp100.0% <ø> (ø)
...sdk-dataservice-read/src/StreamLayerClientImpl.cpp100.0% <ø> (ø)
...-dataservice-read/src/VersionedLayerClientImpl.cpp90.9% <ø> (ø)
...k-dataservice-read/src/VolatileLayerClientImpl.cpp92.9% <ø> (ø)
...k-dataservice-read/src/generated/api/StreamApi.cpp100.0% <ø> (ø)
...-read/src/repositories/PrefetchTilesRepository.cpp93.7% <0.0%> (+0.9%)⬆️
...re/include/olp/core/client/CancellationContext.inl92.6% <0.0%> (+7.4%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c7b9b2...6ea989d. Read the comment docs.

Add missing #include for std::find_if()
Add missing #include for std::find() usage
Add #include for std:find()
@here-mikelleyhere-mikelley changed the title Fix compile errorFix compile errorsMay 16, 2020
Add missing #include for std::transform()
add missing include

@andescuandescu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to our repo!

You need to add DCO to your commit message and the commit message needs to have the following structure:

Summarize changes in around 50 characters or less.
Mandatory detailed explanatory text. Wrap it to about 72
characters or so. In some contexts, the first line is treated as the
subject of the commit and the rest of the text as the body. The
blank line separating the summary from the body is critical (unless
you omit the body entirely); various tools like `log`, `shortlog`
and `rebase` can get confused if you run the two together.
Explain the problem that this commit is solving. Focus on why you
are making this change as opposed to how (the code explains that).
Are there side effects or other unintuitive consequences of this
change? Here's the place to explain them.
Optional further paragraphs come after blank lines.
- Bullet points are okay, too.
- Typically a hyphen or asterisk is used for the bullet, preceded
by a single space, with blank lines in between, but conventions
vary here.
All commits need to reference a ticket, again separated by a blank
line from the commit message summary above:
Resolves: ABC-111, #123
Relates-To: ABC-333, #321
See also: ABC-432, #456, #789
Signed-off-by: FirstName LastName <firstname.lastname@here.com>

#include "repositories/PartitionsRepository.h"
#include "repositories/PrefetchTilesRepository.h"

#include <algorithm>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move up between own header and module headers.
See coding style guide -> https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes

#include "repositories/PartitionsRepository.h"
#include "repositories/PrefetchTilesRepository.h"

#include <algorithm>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@here-mikelley@andescu