Skip to content

VersionLayerClient adding GetAggregatedData API - #891

Merged
kzvieriev merged 1 commit into
masterfrom
task/olpedge-1932
Jun 9, 2020
Merged

VersionLayerClient adding GetAggregatedData API#891
kzvieriev merged 1 commit into
masterfrom
task/olpedge-1932

Conversation

@kzvieriev

Copy link
Copy Markdown
Contributor

New API fetches data of a tile or its closest ancestor. It can be useful
when need to load most detailed available data for specified tile. Added
integration tests to cover the API.

Resolves: OLPEDGE-1932

Signed-off-by: Kostiantyn Zvieriev ext-kostiantyn.zvieriev@here.com

@kzvieriev
kzvierievforce-pushed the task/olpedge-1932 branch 2 times, most recently from b44557b to 24a3f1bCompareJune 4, 2020 12:15
@codecov

codecovBot commented Jun 4, 2020

Copy link
Copy Markdown

Codecov Report

Merging #891 into master will increase coverage by 0.2%.
The diff coverage is 98.0%.

Impacted file tree graph

@@ Coverage Diff @@## master #891 +/- ##
========================================
+ Coverage 81.1% 81.2% +0.2% 
========================================
Files 295 302 +7 Lines 10477 10573 +96 ========================================
+ Hits 8494 8589 +95 - Misses 1983 1984 +1 
Impacted FilesCoverage Δ
...nclude/olp/dataservice/read/VersionedLayerClient.h100.0% <ø> (ø)
...-dataservice-read/src/VersionedLayerClientImpl.cpp91.8% <97.4%> (+0.9%)⬆️
...nclude/olp/dataservice/read/AggregatedDataResult.h100.0% <100.0%> (ø)
...-sdk-dataservice-read/src/VersionedLayerClient.cpp94.3% <100.0%> (+0.7%)⬆️
...pp-sdk-authentication/src/AuthenticationClient.cpp75.9% <0.0%> (-4.2%)⬇️
olp-cpp-sdk-authentication/src/TokenEndpoint.cpp89.1% <0.0%> (-0.2%)⬇️
...e-read/src/generated/parser/VersionInfosParser.cpp100.0% <0.0%> (ø)
...ude/olp/dataservice/read/model/VersionDependency.h100.0% <0.0%> (ø)
.../include/olp/dataservice/read/model/VersionInfos.h100.0% <0.0%> (ø)
...k-authentication/src/AuthenticationClientUtils.cpp96.9% <0.0%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7359731...5756c20. Read the comment docs.

mykhailo-kuchma
mykhailo-kuchma previously approved these changes Jun 4, 2020
Comment threadolp-cpp-sdk-dataservice-read/include/olp/dataservice/read/Types.h Outdated
Comment threadolp-cpp-sdk-dataservice-read/src/VersionedLayerClientImpl.cpp Outdated
Comment threadolp-cpp-sdk-dataservice-read/src/VersionedLayerClientImpl.cpp Outdated
Comment threadolp-cpp-sdk-dataservice-read/src/VersionedLayerClientImpl.cpp Outdated
mykhailo-kuchma
mykhailo-kuchma previously approved these changes Jun 5, 2020
meravingen123
meravingen123 previously approved these changes Jun 5, 2020
Comment threadtests/integration/olp-cpp-sdk-dataservice-read/VersionedLayerClientTest.cpp Outdated
Comment threadtests/integration/olp-cpp-sdk-dataservice-read/VersionedLayerClientTest.cpp Outdated
Comment threadtests/integration/olp-cpp-sdk-dataservice-read/VersionedLayerClientTest.cpp Outdated
Comment threadtests/integration/olp-cpp-sdk-dataservice-read/VersionedLayerClientTest.cpp Outdated
@kzvieriev
kzvierievforce-pushed the task/olpedge-1932 branch 3 times, most recently from 3decf25 to 26a5a0fCompareJune 9, 2020 08:13
andescu
andescu previously approved these changes Jun 9, 2020
New API fetches data of a tile or its closest ancestor. It can be
useful when need to load most detailed available data for specified
tile. Added integration tests to cover the API.�
Resolves: OLPEDGE-1932
Signed-off-by: Kostiantyn Zvieriev <ext-kostiantyn.zvieriev@here.com>
@kzvieriev
kzvieriev merged commit b3a7ec8 into masterJun 9, 2020
@kzvieriev
kzvieriev deleted the task/olpedge-1932 branch June 9, 2020 12:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@kzvieriev@meravingen123@mykhailo-kuchma@andescu