Uh oh!
There was an error while loading. Please reload this page.
Provide math.h from hermit-builtins - #654
Merged
Merged
Conversation
mkroening
marked this pull request as ready for review
February 12, 2023 22:33
Dylan-DPC added a commit
to Dylan-DPC/rust
that referenced
this pull request
Feb 13, 2023
Hermit: Remove floor symbol This symbol should be provided by Hermit. It was introduced in 2019 (rust-lang#65167). Since 2020, Hermit provides these math functions on its own (hermit-os/hermit-rs#37). I think moving this to Hermit was merely an oversight. Related: * hermit-os/kernel#654 * hermit-os/hermit-rs#406 CC: `@stlankes`
stlankes
commented
Feb 13, 2023
Contributor
I am little bit lost. Why do you move the math symbols? |
mkroening
commented
Feb 14, 2023
MemberAuthor
bors r=stlankes |
Contributor
thomcc pushed a commit
to pgcentralfoundation/postgrestd
that referenced
this pull request
May 31, 2023
Hermit: Remove floor symbol This symbol should be provided by Hermit. It was introduced in 2019 (rust-lang/rust#65167). Since 2020, Hermit provides these math functions on its own (hermit-os/hermit-rs#37). I think moving this to Hermit was merely an oversight. Related: * hermit-os/kernel#654 * hermit-os/hermit-rs#406 CC: `@stlankes`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: