Skip to content

feat!: remove deprecated backup window flag - #710

Draft
phm07 wants to merge 1 commit into
mainfrom
remove-backup-window
Draft

feat!: remove deprecated backup window flag#710
phm07 wants to merge 1 commit into
mainfrom
remove-backup-window

Conversation

@phm07

@phm07phm07 commented Mar 7, 2024

Copy link
Copy Markdown
Contributor

This flag has been deprecated (and not working) since 2018: #147

@phm07phm07 self-assigned this Mar 7, 2024
@codecov

codecovBot commented Mar 7, 2024

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.14%. Comparing base (f2fb321) to head (2bddf46).
⚠️ Report is 485 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #710 +/- ##
==========================================
- Coverage 60.14% 60.14% -0.01% 
==========================================
Files 191 191 Lines 6808 6802 -6 ==========================================
- Hits 4095 4091 -4 + Misses 2099 2098 -1 + Partials 614 613 -1 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jooolajooola changed the title fix: remove deprecated backup window flagfeat: remove deprecated backup window flagMar 7, 2024
@apricoteapricote changed the title feat: remove deprecated backup window flagfeat!: remove deprecated backup window flagMar 8, 2024
@apricoteapricote added this to the v2 milestone Mar 12, 2024
@apricote

Copy link
Copy Markdown
Member

This is a potentially breaking change. Even though this flag shows a warning since 2018, we should try to avoid making breaking changes on purpose.

I have created a v2 milestone and added this PR to it, so we have a list of things to tackle if we decide to work on it.

@phm07
phm07force-pushed the remove-backup-window branch from ca3dfd3 to 2bddf46CompareMay 23, 2024 12:45
@github-actions

Copy link
Copy Markdown
Contributor

This PR has been marked as stale because it has not had recent activity. The bot will close the PR if no further action occurs.

@github-actionsgithub-actionsBot added stale and removed stale labels Aug 21, 2024
@github-actions

Copy link
Copy Markdown
Contributor

This PR has been marked as stale because it has not had recent activity. The bot will close the PR if no further action occurs.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@phm07@apricote@jooola