fix(pretext-native): replace workspace:^ dependency with semver range - #1
Open
mandrade2 wants to merge 1 commit into
Open
fix(pretext-native): replace workspace:^ dependency with semver range#1mandrade2 wants to merge 1 commit into
mandrade2 wants to merge 1 commit into
Conversation
The published pretext-native@0.0.2 tarball still declares @hexdrinker/pretext-native-core as workspace:^, which npm consumers cannot resolve. Because the release workflow publishes with npm publish (not yarn npm publish), the workspace: protocol is never rewritten to a version range. Using ^0.0.2 keeps local workspace linking (the core package is a workspace member at 0.0.2) while producing a valid manifest on publish. Generated with assistance from an AI agent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pretext-native@0.0.2publishes with aworkspace:^dependency:npm view pretext-native@0.0.2 dependenciesconfirms the published manifest still containsworkspace:^. The release workflow runsnpm publish, which does not rewrite the Yarnworkspace:protocol to a version range (onlyyarn npm publishdoes). As a result npm/Yarn consumers cannot resolve@hexdrinker/pretext-native-coreand are forced to patch around it withresolutions:Fix
Use a concrete semver range. Local workspace linking is unaffected (
coreis a workspace member at0.0.2, so^0.0.2still resolves to the workspace), and the published manifest becomes valid.Note
This requires a republish (e.g.
pretext-native@0.0.3) to take effect for npm consumers. Alternatively, the release workflow could be switched toyarn npm publish, which rewritesworkspace:protocols automatically.