Uh oh!
There was an error while loading. Please reload this page.
cleanup/colors-package-removal - #541
Conversation
jszuminski
commented
Jul 16, 2024
@PaulDalek what do you think about this type of defining colors and styles? Is it okay here in this use case or should we handle them differently? |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Burkhard Vogel-Kreykenbohm <burkhard.vogel@gmx.net>
Co-authored-by: Burkhard Vogel-Kreykenbohm <burkhard.vogel@gmx.net>
Co-authored-by: Burkhard Vogel-Kreykenbohm <burkhard.vogel@gmx.net>
Co-authored-by: Burkhard Vogel-Kreykenbohm <burkhard.vogel@gmx.net>
jszuminski
commented
Jul 17, 2024
Thanks @bvogel! Great suggestions, all applied. |
bvogel
commented
Jul 18, 2024
Glad you liked them, hopefully this get's merged and released soon! |
bvogel
commented
Aug 5, 2024
too bad, didn't make it into 4.0.0 |
What and why?
The goal of this pull request is to get rid of the unnecessary
colorsdependency and perform a slight refactoring of the logging logic. The logging statements (even the longer ones) were shared across multiple files even though they have been exactly the same. If someone wanted to modify them in the future, he or she would have to modify 8 files (which might get tricky).Tasks
colorspackagelogger.jsand most console log statements