Uh oh!
There was an error while loading. Please reload this page.
xtensor: Make HighFive compatible with 0.26. - #36
Merged
Merged
Conversation
1uc
marked this pull request as draft
April 27, 2025 16:39
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
1ucforce-pushed
the
1uc/update-xtensor
branch
7 times, most recently
from
May 3, 2025 14:53
e33138c to
a4b60f8Compare1uc
marked this pull request as ready for review
May 13, 2025 14:50
1uc
commented
May 13, 2025
ContributorAuthor
@matz-e could you please have a look? It doesn't feel clean, but I also completely out of any other ideas. The good feature of this approach is that it can be overridden, e.g. if a user does |
1ucforce-pushed
the
1uc/update-xtensor
branch
2 times, most recently
from
May 30, 2025 18:57
3095ec5 to
5dff8c0CompareXTensor reorganized its headers in 0.26. This commit introduces come logic to guess the correct path: if the compiler is C++17 or later, use `__has_include` to check both locations; otherwise it must be an xtensor version prior to 0.26, because 0.26 onwards require a C++17 compiler.
1uc
commented
Jun 3, 2025
ContributorAuthor
I'm merging this because I still don't have a better idea and I want CI to be green again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XTensor reorganized its headers in 0.26. This commit introduces come logic to guess the correct path: if the compiler is C++17 or later, use
__has_includeto check both locations; otherwise it must be an xtensor version prior to 0.26, because 0.26 onwards require a C++17 compiler.What makes this all a bit more fun is that:
199711regardless of the requested C++ standard.