Added constants to Arithmetic by jremes-foss · Pull Request #20 · hoaproject/Math

jremes-foss · 2015-01-09T19:38:58Z

I added some constants to Arithmetic.php. Thank you and have a nice weekend. :-)

Hywan · 2015-01-09T22:05:36Z

Can't we fine any better names for 1_PI, 2_SQRTPI and 1_SQRT2?

Hywan · 2015-01-09T22:06:04Z

Nice PR, thanks 👍!

jremes-foss · 2015-01-13T21:40:02Z

Hi. You're welcome. I might actually change the names, but there is a logic - LaTeX variable naming convention. 1_PI = 1 / PI, etc.

Hywan · 2015-01-14T08:23:20Z

@NewMan101 Yup, but the actual grammar does not allow to start a constant name by an integer. Do you think we can use another logic here?

We face the same issue here: hoaproject/Ruler#32.

jremes-foss · 2015-01-14T18:36:17Z

Yes, we certainly can. Thanks for notifying me about this, I think I can checkout the latest repo and re-write the array.

Hywan · 2015-01-15T08:03:13Z

Why INVERSE?

Hywan · 2015-01-15T08:03:49Z

@NewMan101 Thank you for your effort :-)! An alternative would be to allow constant to start by an digit if renaming constants is too hard.

Hywan · 2015-01-23T21:56:25Z

@NewMan101 ping 😄?

Hywan · 2015-01-30T12:39:11Z

So constants will not start by a digit. See hoaproject/Ruler#32 and associated PR.

I would like to merge this PR. If there is no pong, I will merge and do the fix myself :-).

jremes-foss · 2015-01-30T13:27:33Z

Hi, sorry if I have been inactive - super busy with work. Pong, I will do this tonight or tomorrow morning.

Hywan · 2015-01-30T13:41:24Z

@NewMan101 No stress, it's open-source :-).

Hywan · 2015-07-27T07:09:43Z

@NewMan101 ping ❤️?

Hywan · 2015-10-13T05:25:37Z

@NewMan101 ping ❤️?

jremes-foss · 2015-10-13T08:50:44Z

Ok, let me just re-write this one to get the naming convention 100% accurate. Sorry for delay.

Hywan · 2015-10-13T11:02:53Z

No worry :-). Just would like to know if we finish this PR for you or not. Feel free!

jremes-foss · 2015-10-13T11:05:50Z

I think I will create a fresh PR from a scratch and new branch after reviewing the naming conventions.

Hywan · 2015-10-13T11:08:26Z

@NewMan101 Why? This is still mergeable. Just run git rebase master if you want an up-to-date codebase.

jremes-foss · 2015-10-13T11:09:34Z

Ok, well... If this is still mergeable I'll do it then using this PR. As far as I know the only issue is that the grammar does not allow to start a constant name by an integer.

Hywan · 2015-10-13T14:04:54Z

Yes, the naming might need to be clarify. I will add new comments bellow.

jremes-foss · 2015-10-13T14:05:19Z

Ok, cheers.

Hywan · 2015-10-13T14:05:43Z

If we follow the existing “logic”, we should have LOG_2_E instead of LOG2E, or maybe LOG_2E.

I chose LOG_2E

Hywan · 2015-10-13T14:06:42Z

Huh, that's a really strange value :-/. When is it useful? If not useful, please remove it.

I kept this constant but renamed it ~~TWO_DIV_SQRT_PI~~INVERSE_SQRT_PI

jremes-foss · 2015-10-16T18:46:59Z

Yea, that's done now... I just need to rebase the whole branch now. I got rid of the last value.

jremes-foss · 2015-10-16T18:49:25Z

Only issue is that the original branch was deleted from my side. So the branch is "unknown branch" at the moment.

Hywan · 2015-10-19T06:50:16Z

@NewMan101 Oh. You can still get the patch and apply it on a new branch. Tips: https://patch-diff.githubusercontent.com/raw/hoaproject/Math/pull/20.patch.

Hywan · 2016-02-24T07:01:48Z

@NewMan101 Hi :-). Is it possible to address the comments please? If not, we will do that by ourselves :-).

jubianchi · 2016-03-04T18:59:48Z

@Hywan I can do this if you want ;)

Hywan · 2016-03-04T19:18:35Z

@jubianchi Please do!

jremes-foss · 2016-03-04T21:04:27Z

Feel free to do that. I think I've lost the relevant data.

Added constants to Arithmetic
7710a10

Hywan reviewed Jan 9, 2015
View reviewed changes

Comment threadVisitor/Arithmetic.php Outdated
HywanJan 9, 2015
Copy link
Copy Markdown
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we fine any better names for 1_PI, 2_SQRTPI and 1_SQRT2?

Hywan added the enhancement label Jan 9, 2015

Hywan self-assigned this Jan 9, 2015

Fixed constant naming convention
94d3520

Hywan reviewed Jan 15, 2015
View reviewed changes

Comment threadVisitor/Arithmetic.php
HywanJan 15, 2015
Copy link
Copy Markdown
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why INVERSE?

Hywan added the in progress label Jul 13, 2015

Hywan added the difficulty: medium label Oct 13, 2015

Hywan reviewed Oct 13, 2015
View reviewed changes

This was referenced Mar 7, 2016
Constants #38
Merged
Improve library #41
Open

Bhoat closed this in #38 Jan 20, 2017

Hywan removed the in progress label Jan 20, 2017

Uh oh!

Conversation

jremes-foss commented Jan 9, 2015

Uh oh!

HywanJan 9, 2015

Choose a reason for hiding this comment

Uh oh!

Hywan commented Jan 9, 2015

Uh oh!

jremes-foss commented Jan 13, 2015

Uh oh!

Hywan commented Jan 14, 2015

Uh oh!

jremes-foss commented Jan 14, 2015

Uh oh!

HywanJan 15, 2015

Choose a reason for hiding this comment

Uh oh!

Hywan commented Jan 15, 2015

Uh oh!

Hywan commented Jan 23, 2015

Uh oh!

Hywan commented Jan 30, 2015

Uh oh!

jremes-foss commented Jan 30, 2015

Uh oh!

Hywan commented Jan 30, 2015

Uh oh!

Hywan commented Jul 27, 2015

Uh oh!

Hywan commented Oct 13, 2015

Uh oh!

jremes-foss commented Oct 13, 2015

Uh oh!

Hywan commented Oct 13, 2015

Uh oh!

jremes-foss commented Oct 13, 2015

Uh oh!

Hywan commented Oct 13, 2015

Uh oh!

jremes-foss commented Oct 13, 2015

Uh oh!

Hywan commented Oct 13, 2015

Uh oh!

jremes-foss commented Oct 13, 2015

Uh oh!

HywanOct 13, 2015

Choose a reason for hiding this comment

Uh oh!

jubianchiMar 7, 2016

Choose a reason for hiding this comment

Uh oh!

HywanOct 13, 2015

Choose a reason for hiding this comment

Uh oh!

jubianchiMar 7, 2016

Choose a reason for hiding this comment

Uh oh!

jremes-foss commented Oct 16, 2015

Uh oh!

jremes-foss commented Oct 16, 2015

Uh oh!

Hywan commented Oct 19, 2015

Uh oh!

Hywan commented Feb 24, 2016

Uh oh!

jubianchi commented Mar 4, 2016

Uh oh!

Hywan commented Mar 4, 2016

Uh oh!

jremes-foss commented Mar 4, 2016

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants