Skip to content
This repository was archived by the owner on Sep 20, 2021. It is now read-only.

Add support for hexadecimal, octal and binary values - #40

Open
jubianchi wants to merge 1 commit into
hoaproject:masterfrom
jubianchi:more-numbers
Open

Add support for hexadecimal, octal and binary values#40
jubianchi wants to merge 1 commit into
hoaproject:masterfrom
jubianchi:more-numbers

Conversation

@jubianchi

@jubianchijubianchi commented Mar 7, 2016

Copy link
Copy Markdown
Member

Users can now use three new notations:

  • \x5390x539 for hexadecimal values
  • \b1010100b101010 for binary values
  • \052052 for octal values

We can also mix them in expressions:

- ( \b101010 * ( \x539 / -\052 ) ) / 100
- ( 0b101010 * ( 0x539 / -052 ) ) / 100

The result here will be 13.37

@jubianchijubianchi mentioned this pull request Mar 7, 2016
Closed
@jubianchi

jubianchi commented Mar 7, 2016

Copy link
Copy Markdown
MemberAuthor

Of course, tests are green:

$ vendor/bin/hoa test:run -d Test/ -p 'php\ -n' -D
...
> Total tests duration: 69.98 seconds.
> Total tests memory usage: 6.00 Mb.
> Running duration: 70.29 seconds.
Success (7 test suites, 42/42 test cases, 0 void test case, 0 skipped test case, 33271 assertions)!

The only drawbacks of those notation are they are not compatible with PHP itself so we cannot directly add them to unit tests :/ We could support native syntax (as @Metalaka pointed out in #39 - http://php.net/manual/en/language.types.integer.php) but we would have to forbid constants/ids starting with digits so that we can use 0x... (hex), 0b... (binary) and 0... (octal).

@CircleCode

CircleCode commented Mar 7, 2016

Copy link
Copy Markdown
Member

this seems weird, but just thinking out loud: what about allowing constants starting by any digit other than 0 (also applicable to #39)

@jubianchi

jubianchi commented Mar 7, 2016

Copy link
Copy Markdown
MemberAuthor

@CircleCode why not :)

what about allowing constants starting by any digit other than 0

Must also apply to ids then ;)

@CircleCode

CircleCode commented Mar 7, 2016

Copy link
Copy Markdown
Member

maybe the question is "why did we want to allow constants starting by digits?" → the answer could help to chose one of the possible solutions amongst

@jubianchi

jubianchi commented Mar 8, 2016

Copy link
Copy Markdown
MemberAuthor

When talking with @Hywan about supporting constants/ids starting with digits, I talked about "side effects": this one is a side-effects. It prevents us from implementing something interesting with a generic notation.

My opinion is: let's close #39 and change constant names in #38 to something like TWO_OVER_PI instead of 2_OVER_PI and use generic notations here.

@CircleCode

CircleCode commented Mar 8, 2016

Copy link
Copy Markdown
Member

I share @jubianchi 's opinion.
This would make us more standard

@HywanHywan self-assigned this Mar 8, 2016
@Hywan

Hywan commented Mar 8, 2016

Copy link
Copy Markdown
Member

See my comment in #39.

@Metalaka

Metalaka commented Mar 8, 2016

Copy link
Copy Markdown
Member

@jubianchi@CircleCode 👍
We love standards :)

@Hywan

Hywan commented Mar 9, 2016

Copy link
Copy Markdown
Member

👍

@jubianchijubianchi mentioned this pull request Mar 9, 2016
Open
6 tasks
jubianchi
jubianchi reviewed Mar 9, 2016
View reviewed changes
Comment threadTest/Unit/Visitor/Arithmetic.php
new LUT\Sampler\Random()
),
9
7

@jubianchijubianchiMar 9, 2016

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this value because with 9 the test suite generated more than a million expressions and I could not reach the end of the test... way tooooooo long :)

@jubianchijubianchiMar 9, 2016

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried with 8 which produce a reasonable test suite (~200 seconds AFAIR) but ended up getting the #42 bug :/

@jubianchi

jubianchi commented Mar 9, 2016

Copy link
Copy Markdown
MemberAuthor
> Total tests duration: 143.03 seconds.
> Total tests memory usage: 6.00 Mb.
> Running duration: 143.20 seconds.
Success (7 test suites, 42/42 test cases, 0 void test case, 0 skipped test case, 103047 assertions)!

Hywan
Hywan reviewed Mar 11, 2016
View reviewed changes
Comment threadVisitor/Arithmetic.php Outdated
} elseif ('id' === $token) {
return $value;
} elseif ('binary' === $token || 'hex' === $token || 'octal' === $token) {
$out = (float) eval('return ' . $value . ';');

@HywanHywanMar 11, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STOP THIS!!!

@HywanHywanMar 11, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For binary: bindec.
For hexa: hexdec.
For octal: octdec.

@jubianchijubianchiMar 11, 2016

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does not work!!!!!!

@HywanHywanMar 11, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

@jubianchijubianchiMar 11, 2016

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the only way to make them work is by trimming litterals before passing them to *dec : bindec(str_replace('0b', '', $binary));

@HywanHywanMar 11, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So do it. That's by far faster than using an eval. Also, eval is not caught by the opcode cache.

@jubianchi

jubianchi commented Mar 11, 2016

Copy link
Copy Markdown
MemberAuthor

thanks for the review. Updates will be done today

@Hywan

Hywan commented Mar 11, 2016

Copy link
Copy Markdown
Member

❤️

@jubianchi

jubianchi commented Mar 11, 2016

Copy link
Copy Markdown
MemberAuthor

@hoaproject/hoackers need review :)

@jubianchi
Add support for hexadecimal, octal and binary values
0016d6c
Users can now use three new notations:
* `0x539` for hexadecimal values
* `0b101010` for binary values
* `052` for octal values
We can also mix them in expressions:
```
- ( 0b101010 * ( 0x539 / -052 ) ) / 100
```
The result here will be `13.37`
Hywan
Hywan reviewed Mar 11, 2016
View reviewed changes
Comment threadTest/Unit/Visitor/Arithmetic.php
)
->then
->object($compiler->parse($hexadecimalNumber))
->isInstanceOf('Hoa\Compiler\Llk\TreeNode')

@HywanHywanMar 11, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can check the ID and the value of the token (resp. token and hexadecimal).
Same for subsequent test cases.

@Hywan

Hywan commented May 9, 2016•
edited
Loading

Copy link
Copy Markdown
Member

Review done. Need a little bit more corrections :-).

@Hywan

Hywan commented May 9, 2016

Copy link
Copy Markdown
Member

And some test cases for overflows.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@HywanHywan

Labels

difficulty: mediumenhancementin progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jubianchi@CircleCode@Hywan@Metalaka