Uh oh!
There was an error while loading. Please reload this page.
fix(errors): surface server code + message on coded 403s (AIT-151) - #15
Merged
Conversation
The 403 branch in mapApiError collapsed almost every 403 into the blanket "This action requires workspace admin permission." string plus re-login guidance, hiding the server's real reason for denials like AGENT_KEY_REVOKE_SELF_ONLY. - Coded 403s (any code beyond the existing SESSION_WINDOW_CLOSED / INSTAGRAM_DISABLED special cases) now surface the server's own code and message via a new ForbiddenError (exit 3, the 403 permission tier). A bare 403 with no server code still falls back to the admin-guidance PermissionError. - Generic 4xx fallbacks now preserve the server's code so scripts reading --json can branch on it instead of a flat API_ERROR. - The --json error envelope now prefers a machine-clean single-line message when an error carries one (PermissionError), instead of emitting its multi-line human CLI guidance.
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughCoded 403 responses now preserve server-provided codes and messages through API error mapping and JSON output. A new ChangesCoded 403 Error Handling
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant apiClient
participant mapApiError
participant ForbiddenError
participant doctor
apiClient->>mapApiError: Process coded 403 response
mapApiError->>ForbiddenError: Create with server message and code
ForbiddenError-->>apiClient: Return exitCode 3 error
doctor->>apiClient: Validate credentials
apiClient-->>doctor: Return ForbiddenError
doctor->>doctor: Classify credential failure
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:9e0b2f2238
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ord669 added a commit
that referenced
this pull request
Aug 12, 2026
* fix(errors): surface server code + message on coded 403s (AIT-151) The 403 branch in mapApiError collapsed almost every 403 into the blanket "This action requires workspace admin permission." string plus re-login guidance, hiding the server's real reason for denials like AGENT_KEY_REVOKE_SELF_ONLY. - Coded 403s (any code beyond the existing SESSION_WINDOW_CLOSED / INSTAGRAM_DISABLED special cases) now surface the server's own code and message via a new ForbiddenError (exit 3, the 403 permission tier). A bare 403 with no server code still falls back to the admin-guidance PermissionError. - Generic 4xx fallbacks now preserve the server's code so scripts reading --json can branch on it instead of a flat API_ERROR. - The --json error envelope now prefers a machine-clean single-line message when an error carries one (PermissionError), instead of emitting its multi-line human CLI guidance. * fix(doctor): treat coded 403s (ForbiddenError) as rejected credentials
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem (AIT-151)
mapApiError's 403 branch collapsed almost every 403 into the blanketThis action requires workspace admin permission.string plus re-loginguidance. That hid the server's real reason for specific denials — e.g. a
self-only revoke (
AGENT_KEY_REVOKE_SELF_ONLY) showed the wrong "ask youradmin" message. The
--jsonerror output also carried the multi-line humanCLI guidance instead of a machine-clean message.
Changes
codebeyond the existingSESSION_WINDOW_CLOSED/INSTAGRAM_DISABLEDspecial cases) now surface the server's owncodeandmessage via a new
ForbiddenError(exit 3, the 403 permission tier). A bare403 with no server code still falls back to the admin-guidance
PermissionError.codeso scripts reading--jsoncan branch on it instead of a flatAPI_ERROR.--jsonerror envelope prefers a machine-clean single-line message whenan error carries one (
PermissionError.jsonMessage), instead of emitting itsmulti-line human guidance.
Verification
AGENT_KEY_REVOKE_SELF_ONLY) surfaces the servermessage + code and exits 3;
PermissionError--jsonmessage is a cleansingle line;
ForbiddenErrorcarries server code/message.tsc --noEmitclean, build succeeds.Summary by CodeRabbit