Uh oh!
There was an error while loading. Please reload this page.
AIT-239: Add zero-touch Claude MCP authentication - #29
Merged
Conversation
📝 WalkthroughWalkthroughAdds Claude MCP installation and management commands, centralizes valid access-token retrieval, integrates MCP setup and cleanup into authentication flows, and reports MCP status through ChangesClaude MCP integration
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant User
participant CLI
participant ClaudeCode
participant ApiClient
User->>CLI: login
CLI->>ClaudeCode: install MCP configuration
ClaudeCode-->>CLI: installation result
ClaudeCode->>CLI: invoke mcp-headers
CLI->>ApiClient: getValidAccessToken()
ApiClient-->>CLI: valid access token
CLI-->>ClaudeCode: Authorization header JSON
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/auth/login.ts`:
- Line 94: Decouple maybeInstallClaudeMcp() from the synchronous login path so
hookmyapp login completes after credentials are saved even if the Claude CLI
stalls. Prefer moving the MCP setup out of the login flow; otherwise ensure
every Claude CLI operation within maybeInstallClaudeMcp has a bounded timeout
while preserving setup behavior.
In `@src/auth/logout.ts`:
- Line 34: Update the logout flow around removeClaudeMcp() to capture and
propagate its cleanup status instead of ignoring the spawnSync result. Preserve
credential deletion, but ensure both human-readable and JSON logout output
report failure when the user-scoped Claude MCP entry is not removed, rather than
printing logged_out unconditionally.
In `@src/commands/doctor.ts`:
- Around line 41-42: Update getClaudeMcpStatus to invoke the Claude CLI with a
bounded spawnSync timeout, detect ETIMEDOUT from the probe result or error, and
return an informational MCP failure instead of allowing doctor to hang; preserve
the existing status handling for non-timeout outcomes.
In `@src/commands/mcp.ts`:
- Around line 26-30: Bound every claude subprocess invocation with one shared
spawnSync timeout configuration and handle timeout errors consistently. Update
the mcp add-json retry at src/commands/mcp.ts:26-30, the --version call at
src/commands/mcp.ts:42-43, the mcp remove call at src/commands/mcp.ts:56-58, and
the mcp get call at src/commands/mcp.ts:62-64; preserve existing retry and
command-result behavior while ensuring timed-out calls do not block
indefinitely.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: d1a4c2e3-09cb-4585-98b2-e131de8466c1
📒 Files selected for processing (7)
src/api/client.tssrc/auth/login.tssrc/auth/logout.tssrc/commands/__tests__/mcp.test.tssrc/commands/doctor.tssrc/commands/mcp.tssrc/index.ts
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:aa4fdcf1cf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ord669 added a commit
that referenced
this pull request
Aug 12, 2026
This was referenced Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- configure HookMyApp MCP automatically after successful CLI login\n- supply fresh bearer headers through a dynamic helper without persisting tokens in Claude config\n- remove config on logout and expose MCP health in doctor\n\n## Validation\n- 109 targeted integration/help tests pass\n- TypeScript check and build pass\n- live Claude MCP status reports connected\n\nLinear: AIT-239
Summary by CodeRabbit
New Features
mcp install --agent claudecommand and hidden header support for MCP clients.Bug Fixes
Tests